Port #1278 to dtq-dev-9-base: UFAL/Add New version button for archived submission items (#1278) (#1503)

/mydspace lists an archived submission with a single action, View. To start a new
version of it the submitter had to navigate to the item page and find the versioning
menu. This adds a Create new version button next to View, gated on the same
authorization feature and backed by the same vanilla services the item page uses:

- the button renders only when the user holds FeatureID.CanCreateVersion on the item
  (canCreateVersion$);
- it is disabled, with a tooltip and a matching aria-label, while a draft already
  exists in the version history (disableNewVersion$ / newVersionTooltip$, both from
  DsoVersioningModalService.isNewVersionButtonDisabled and getVersioningTooltipMessage,
  keys item.page.version.hasDraft / item.page.version.create - both already present in
  en.json5 and cs.json5);
- clicking it opens the existing versioning modal.

initVersioningControls() seeds the three observables with safe defaults and returns
early unless the item has both a self link and a version link, so a partially loaded
object cannot fire an authorization request against undefined.

v9 notes (this is a translate, not a transplant):
- ItemActionsComponent is standalone here, so imports[] gains AsyncPipe (the template
  is all `| async`) and BtnDisabledDirective (the source already uses [dsBtnDisabled]).
  Missing either is the wiring-dropped failure mode - the template would silently stop
  resolving the pipe or the directive.
- *ngIf -> @if; Bootstrap 4 ml-1 -> Bootstrap 5 ms-1 (9-base has 0 ml-1 in src/**/*.html).
- rxjs `of as observableOf` -> `of`; the spec is a standalone TestBed, so the new
  providers go alongside the existing ones and no declarations are needed.
- DEVIATION: the source pipes `shareReplay(1)`. That form is a lint error on this
  branch - @smarttools/rxjs/no-sharereplay, "shareReplay is forbidden unless a config
  argument is passed". It is written here as the exactly equivalent
  `shareReplay({ bufferSize: 1, refCount: false })`, which is also the idiom the rest of
  this branch uses (access-control-form-container, log-in-password).

Spec: 1 test -> 6. The five new ones cover shown-when-authorized, hidden-when-not,
disabled state, the tooltip key coming from getVersioningTooltipMessage, and the modal
opening on click.

Card PB-04 (tranche T3).

Source: f46cb9c (dtq-dev PR #1278)

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>

Author: milanmajchrak

src/app/shared/mydspace-actions/item/item-actions.component.html

@@ -3,3 +3,13 @@
             [routerLink]="[itemPageRoute]">
   <i class="fa fa-info-circle"></i> {{"submission.workflow.generic.view" | translate}}
 </button>
+
+@if (canCreateVersion$ | async) {
+  <button class="btn btn-outline-primary mt-1 mb-3 ms-1"
+          [dsBtnDisabled]="disableNewVersion$ | async"
+          [ngbTooltip]="(newVersionTooltip$ | async) | translate"
+          [attr.aria-label]="(newVersionTooltip$ | async) | translate"
+          (click)="openCreateVersionModal()">
+    <i class="fas fa-code-branch"></i> {{ 'item.page.version.create' | translate }}
+  </button>
+}

src/app/shared/mydspace-actions/item/item-actions.component.spec.ts

@@ -8,6 +8,7 @@ import {
   TestBed,
   waitForAsync,
 } from '@angular/core/testing';
+import { By } from '@angular/platform-browser';
 import {
   Router,
   RouterLink,
@@ -18,10 +19,12 @@ import {
 } from '@ngx-translate/core';
 import { of } from 'rxjs';
 
+import { AuthorizationDataService } from '../../../core/data/feature-authorization/authorization-data.service';
 import { ItemDataService } from '../../../core/data/item-data.service';
 import { RequestService } from '../../../core/data/request.service';
 import { Item } from '../../../core/shared/item.model';
 import { SearchService } from '../../../core/shared/search/search.service';
+import { DsoVersioningModalService } from '../../dso-page/dso-versioning-modal-service/dso-versioning-modal.service';
 import { getMockRequestService } from '../../mocks/request.service.mock';
 import { getMockSearchService } from '../../mocks/search-service.mock';
 import { TranslateLoaderMock } from '../../mocks/translate-loader.mock';
@@ -37,7 +40,25 @@ let mockObject: Item;
 
 const mockDataService = {};
 
+const authorizationService = jasmine.createSpyObj('authorizationService', {
+  isAuthorized: of(true),
+});
+
+const dsoVersioningModalService = jasmine.createSpyObj('dsoVersioningModalService', {
+  isNewVersionButtonDisabled: of(false),
+  getVersioningTooltipMessage: of('item.page.version.create'),
+  openCreateVersionModal: undefined,
+});
+
 mockObject = Object.assign(new Item(), {
+  _links: {
+    self: {
+      href: 'https://rest.test/server/api/core/items/item-id',
+    },
+    version: {
+      href: 'https://rest.test/server/api/core/versions/1',
+    },
+  },
   bundles: of({}),
   metadata: {
     'dc.title': [
@@ -90,6 +111,8 @@ describe('ItemActionsComponent', () => {
         { provide: NotificationsService, useValue: new NotificationsServiceStub() },
         { provide: SearchService, useValue: searchService },
         { provide: RequestService, useValue: requestServce },
+        { provide: AuthorizationDataService, useValue: authorizationService },
+        { provide: DsoVersioningModalService, useValue: dsoVersioningModalService },
       ],
       schemas: [NO_ERRORS_SCHEMA],
     }).overrideComponent(ItemActionsComponent, {
@@ -99,6 +122,14 @@ describe('ItemActionsComponent', () => {
   }));
 
   beforeEach(() => {
+    authorizationService.isAuthorized.calls.reset();
+    authorizationService.isAuthorized.and.returnValue(of(true));
+    dsoVersioningModalService.isNewVersionButtonDisabled.calls.reset();
+    dsoVersioningModalService.isNewVersionButtonDisabled.and.returnValue(of(false));
+    dsoVersioningModalService.getVersioningTooltipMessage.calls.reset();
+    dsoVersioningModalService.getVersioningTooltipMessage.and.returnValue(of('item.page.version.create'));
+    dsoVersioningModalService.openCreateVersionModal.calls.reset();
+
     fixture = TestBed.createComponent(ItemActionsComponent);
     component = fixture.componentInstance;
     component.object = mockObject;
@@ -117,4 +148,70 @@ describe('ItemActionsComponent', () => {
     expect(component.object).toEqual(mockObject);
   });
 
+  it('should show the New version button when version creation is authorized', () => {
+    fixture.detectChanges();
+
+    const newVersionButton = fixture.debugElement.query(By.css('button.btn-outline-primary'));
+
+    expect(newVersionButton).toBeTruthy();
+  });
+
+  it('should hide the New version button when version creation is not authorized', () => {
+    authorizationService.isAuthorized.and.returnValue(of(false));
+
+    fixture = TestBed.createComponent(ItemActionsComponent);
+    component = fixture.componentInstance;
+    component.object = mockObject;
+    fixture.detectChanges();
+
+    const newVersionButton = fixture.debugElement.query(By.css('button.btn-outline-primary'));
+
+    expect(newVersionButton).toBeNull();
+  });
+
+  it('should mark the New version button as disabled when version creation is disabled', () => {
+    dsoVersioningModalService.isNewVersionButtonDisabled.and.returnValue(of(true));
+
+    fixture = TestBed.createComponent(ItemActionsComponent);
+    component = fixture.componentInstance;
+    component.object = mockObject;
+    fixture.detectChanges();
+
+    let isDisabled: boolean;
+    component.disableNewVersion$.subscribe((value) => {
+      isDisabled = value;
+    });
+
+    expect(isDisabled).toBeTrue();
+  });
+
+  it('should use getVersioningTooltipMessage to derive tooltip key', () => {
+    dsoVersioningModalService.isNewVersionButtonDisabled.and.returnValue(of(true));
+    dsoVersioningModalService.getVersioningTooltipMessage.and.returnValue(of('item.page.version.hasDraft'));
+
+    fixture = TestBed.createComponent(ItemActionsComponent);
+    component = fixture.componentInstance;
+    component.object = mockObject;
+    fixture.detectChanges();
+
+    let tooltipKey: string;
+    component.newVersionTooltip$.subscribe((value) => {
+      tooltipKey = value;
+    });
+
+    expect(tooltipKey).toBe('item.page.version.hasDraft');
+    expect(dsoVersioningModalService.getVersioningTooltipMessage)
+      .toHaveBeenCalledWith(mockObject, 'item.page.version.hasDraft', 'item.page.version.create');
+  });
+
+  it('should open the create version modal when the New version button is clicked', () => {
+    fixture.detectChanges();
+
+    const newVersionButton = fixture.debugElement.query(By.css('button.btn-outline-primary'));
+
+    newVersionButton.triggerEventHandler('click');
+
+    expect(dsoVersioningModalService.openCreateVersionModal).toHaveBeenCalledWith(mockObject);
+  });
+
 });

src/app/shared/mydspace-actions/item/item-actions.component.ts

@@ -1,3 +1,4 @@
+import { AsyncPipe } from '@angular/common';
 import {
   Component,
   Injector,
@@ -13,12 +14,22 @@ import {
   TranslateModule,
   TranslateService,
 } from '@ngx-translate/core';
+import {
+  Observable,
+  of,
+} from 'rxjs';
+import { shareReplay } from 'rxjs/operators';
 
+import { AuthorizationDataService } from '../../../core/data/feature-authorization/authorization-data.service';
+import { FeatureID } from '../../../core/data/feature-authorization/feature-id';
 import { ItemDataService } from '../../../core/data/item-data.service';
 import { RequestService } from '../../../core/data/request.service';
 import { Item } from '../../../core/shared/item.model';
 import { SearchService } from '../../../core/shared/search/search.service';
 import { getItemPageRoute } from '../../../item-page/item-page-routing-paths';
+import { BtnDisabledDirective } from '../../btn-disabled.directive';
+import { DsoVersioningModalService } from '../../dso-page/dso-versioning-modal-service/dso-versioning-modal.service';
+import { hasValue } from '../../empty.util';
 import { NotificationsService } from '../../notifications/notifications.service';
 import { MyDSpaceActionsComponent } from '../mydspace-actions';
 
@@ -30,6 +41,8 @@ import { MyDSpaceActionsComponent } from '../mydspace-actions';
   styleUrls: ['./item-actions.component.scss'],
   templateUrl: './item-actions.component.html',
   imports: [
+    AsyncPipe,
+    BtnDisabledDirective,
     NgbTooltip,
     RouterLink,
     TranslateModule,
@@ -48,6 +61,21 @@ export class ItemActionsComponent extends MyDSpaceActionsComponent<Item, ItemDat
    */
   itemPageRoute: string;
 
+  /**
+   * Whether the current user can create a new version for this item.
+   */
+  canCreateVersion$: Observable<boolean>;
+
+  /**
+   * Whether the New version button should be disabled.
+   */
+  disableNewVersion$: Observable<boolean>;
+
+  /**
+   * Tooltip key for the New version button.
+   */
+  newVersionTooltip$: Observable<string>;
+
   /**
    * Initialize instance variables
    *
@@ -63,12 +91,15 @@ export class ItemActionsComponent extends MyDSpaceActionsComponent<Item, ItemDat
               protected notificationsService: NotificationsService,
               protected translate: TranslateService,
               protected searchService: SearchService,
-              protected requestService: RequestService) {
+              protected requestService: RequestService,
+              protected authorizationService: AuthorizationDataService,
+              protected dsoVersioningModalService: DsoVersioningModalService) {
     super(Item.type, injector, router, notificationsService, translate, searchService, requestService);
   }
 
   ngOnInit(): void {
     this.initPageRoute();
+    this.initVersioningControls();
   }
 
   /**
@@ -79,6 +110,7 @@ export class ItemActionsComponent extends MyDSpaceActionsComponent<Item, ItemDat
   initObjects(object: Item) {
     this.object = object;
     this.initPageRoute();
+    this.initVersioningControls();
   }
 
   /**
@@ -88,4 +120,35 @@ export class ItemActionsComponent extends MyDSpaceActionsComponent<Item, ItemDat
     this.itemPageRoute = getItemPageRoute(this.object);
   }
 
+  /**
+   * Initialize authorization and button state for version creation.
+   */
+  initVersioningControls(): void {
+    this.canCreateVersion$ = of(false);
+    this.disableNewVersion$ = of(false);
+    this.newVersionTooltip$ = of('item.page.version.create');
+
+    if (!hasValue(this.object?.self) || !hasValue(this.object?._links?.version?.href)) {
+      return;
+    }
+
+    this.canCreateVersion$ = this.authorizationService.isAuthorized(
+      FeatureID.CanCreateVersion,
+      this.object.self,
+    );
+    this.disableNewVersion$ = this.dsoVersioningModalService.isNewVersionButtonDisabled(this.object).pipe(shareReplay({ bufferSize: 1, refCount: false }));
+    this.newVersionTooltip$ = this.dsoVersioningModalService.getVersioningTooltipMessage(
+      this.object,
+      'item.page.version.hasDraft',
+      'item.page.version.create',
+    );
+  }
+
+  /**
+   * Open the existing Create version modal for the current item.
+   */
+  openCreateVersionModal(): void {
+    this.dsoVersioningModalService.openCreateVersionModal(this.object);
+  }
+
 }