Skip to content

Commit 4cc70b8

Browse files
Matus Kasakclaude
andcommitted
Trim comments to match dtq-dev; drop issue refs and redundant notes
Remove issue-tracker references and extra explanatory comments from the frontend deployed-version files, aligning comment style with dtq-dev, and drop the redundant explicit 'standalone: true' on the pipe (default in Angular 20). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
1 parent 8012b3a commit 4cc70b8

6 files changed

Lines changed: 4 additions & 20 deletions

File tree

.github/workflows/docker.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ jobs:
3434
tags_flavor: suffix=-dev
3535
# As this is a "dev" image, its tags are all suffixed with "-dev". Otherwise, it uses the same
3636
# tagging logic as the primary 'dspace/dspace-angular' image above.
37-
# Generate deployed-version info served at /static/VERSION_D (issue #813)
3837
run_python_version_script: true
3938
python_version_script_dest: src/static-files/VERSION_D.html
4039
secrets:
@@ -53,7 +52,6 @@ jobs:
5352
build_id: dspace-angular
5453
image_name: dataquest/dspace-angular
5554
dockerfile_path: ./Dockerfile.dist
56-
# Generate deployed-version info served at /static/VERSION_D (issue #813)
5755
run_python_version_script: true
5856
python_version_script_dest: src/static-files/VERSION_D.html
5957
secrets:

src/app/shared/html-content.service.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,7 @@ interface HtmlContentResult {
2626
}
2727

2828
/**
29-
* Service for loading static `.html` files stored in the `src/static-files` folder
30-
* (registered as a build asset in `angular.json`). Used e.g. to render the
31-
* deployed-version info at `/static/VERSION_D` (issue #813).
29+
* Service for loading static `.html` files stored in the `/static-files` folder.
3230
*/
3331
@Injectable({
3432
providedIn: 'root',

src/app/shared/utils/clarin-safehtml.pipe.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ import {
1212
*/
1313
@Pipe({
1414
name: 'dsSafeHtml',
15-
standalone: true,
1615
})
1716
export class ClarinSafeHtmlPipe implements PipeTransform {
1817
constructor(private sanitized: DomSanitizer) {}

src/app/static-page/static-page-routing-paths.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,5 @@
11
/**
22
* Constants for the `/static` route.
3-
*
4-
* The static page component loads `.html` files bundled from `src/static-files`
5-
* (registered as a build asset in `angular.json`). This is how the deployed-version
6-
* info is served at `/static/VERSION_D` (issue #813).
73
*/
84
export const STATIC_PAGE_PATH = 'static';
95

src/app/static-page/static-page.component.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,8 @@ import { HtmlContentService } from '../shared/html-content.service';
1414
import { ClarinSafeHtmlPipe } from '../shared/utils/clarin-safehtml.pipe';
1515

1616
/**
17-
* Component which loads and shows static files from the `src/static-files` folder.
18-
* E.g. `<UI_URL>/static/VERSION_D` renders `static-files/VERSION_D.html`
19-
* (the deployed-version info, issue #813).
17+
* Component which load and show static files from the `static-files` folder.
18+
* E.g., `<UI_URL>/static/some_file` loads the content from `static-files/some_file.html`.
2019
*/
2120
@Component({
2221
selector: 'ds-static-page',

src/static-files/VERSION_D.html

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1 @@
1-
<!--
2-
Placeholder for the deployed-version info (issue #813).
3-
This file is regenerated at Docker/CI build time by scripts/sourceversion.py
4-
and served at /static/VERSION_D. The committed placeholder only ensures the
5-
src/static-files directory exists so the build-time redirection and the
6-
angular.json asset copy succeed.
7-
-->
1+
<!-- Regenerated at build time by scripts/sourceversion.py and served at /static/VERSION_D. -->

0 commit comments

Comments
 (0)