ORCID enhancement working - todo cleanup the code

Author: milanmajchrak

src/app/core/submission/vocabularies/vocabulary.service.spec.ts

@@ -25,6 +25,7 @@ import { createPaginatedList } from '../../../shared/testing/utils.test';
 import { RequestEntry } from '../../data/request-entry.model';
 import { VocabularyDataService } from './vocabulary.data.service';
 import { VocabularyEntryDetailsDataService } from './vocabulary-entry-details.data.service';
+import { ExternalSourceDataService } from '../../data/external-source-data.service';
 
 describe('VocabularyService', () => {
   let scheduler: TestScheduler;
@@ -34,6 +35,7 @@ describe('VocabularyService', () => {
   let objectCache: ObjectCacheService;
   let halService: HALEndpointService;
   let hrefOnlyDataService: HrefOnlyDataService;
+  let externalSourceDataService: ExternalSourceDataService;
   let responseCacheEntry: RequestEntry;
 
   const vocabulary: any = {
@@ -205,11 +207,13 @@ describe('VocabularyService', () => {
 
   function initTestService() {
     hrefOnlyDataService = getMockHrefOnlyDataService();
+    externalSourceDataService = jasmine.createSpyObj('ExternalSourceDataService', ['findAll', 'findById']);
 
     return new VocabularyService(
       requestService,
       new VocabularyDataService(requestService, rdbService, objectCache, halService),
       new VocabularyEntryDetailsDataService(requestService, rdbService, objectCache, halService),
+      externalSourceDataService,
     );
   }