Commit 5f16046
TESTS-ONLY completion of the #1292 port. The runtime hunk (the CLARIN license
section PATCHes /sections/clarin-license/select instead of sections.license)
arrived with the v9 squash, and the karma spec that pins the PATCH path arrived
with #1396 (card FE-25) - section-license.component.spec.ts already asserts
body[0].path === '/sections/clarin-license/select'. Nothing to add there.
What was still missing is the e2e half. #1292 also hardened
cypress/e2e/submission-ui.cy.ts so that the CLARIN licence section's card
header is asserted to carry the green status icon (.fa-check-circle.text-success,
15 s timeout) when no file has been uploaded. That file does not exist on the v9
base - the fork's submission-ui.cy.ts was replaced by the vanilla
submission.cy.ts - so the step is adapted into submission.cy.ts instead.
v9 notes:
- The step is conditional on div[id="section_clarin-license"] existing (decision
D-03). CI e2e runs against a vanilla backend image, which does not ship the
clarin-license submission step, so an unconditional step would fail there. On a
CLARIN backend the section is present and the assertions run.
- It is placed in the first test ("should create a new submission when using
/submit path"), which uploads no file - the same precondition as the fork's
"should not show validation warnings when no file is uploaded (metadata-only)"
test the hunk came from.
- The fork's cy.wait(1000) settle and the 15 s retry timeout are kept verbatim.
- No cy./expect() step is removed or weakened (guard X6).
Card PB-08 (tranche T3).
Source: 0645e7e (dtq-dev PR #1292)
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
1 parent 6ff55c2 commit 5f16046
1 file changed
Lines changed: 36 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
46 | 46 | | |
47 | 47 | | |
48 | 48 | | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
49 | 85 | | |
50 | 86 | | |
51 | 87 | | |
| |||
0 commit comments