Skip to content

Commit 640a076

Browse files
committed
Refactor by Copilot's suggestions
1 parent f6b1896 commit 640a076

2 files changed

Lines changed: 13 additions & 5 deletions

File tree

src/app/item-page/versions/item-versions.component.html

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
<div *ngIf="(versionsDTO$ | async) as versionsDTO; else noItemVersion" class="mb-2">
22
<div *ngIf="(versionRD$ | async)?.payload as itemVersion">
3-
3+
44
<!-- Toggle Header -->
5-
<div class="d-flex align-items-center mb-2" style="cursor: pointer;" (click)="toggleVersionHistory()">
5+
<div class="d-flex align-items-center mb-2 cursor-pointer" (click)="toggleVersionHistory()">
66
<h4 class="mb-0 me-2">{{ "item.version.history.head" | translate }}</h4>
77
<i class="fas" [ngClass]="showVersionHistory ? 'fa-chevron-up' : 'fa-chevron-down'"></i>
88
</div>
@@ -39,13 +39,13 @@ <h4 class="mb-0 me-2">{{ "item.version.history.head" | translate }}</h4>
3939
<ng-template #itemNameWithLink>
4040
<ng-container *ngIf="(versionDTO.version.item | async)?.payload as versionItem">
4141
<a [routerLink]="getVersionRoute(versionDTO.version.id)">
42-
{{ versionItem.firstMetadataValue('dc.title') || versionItem.name || 'Untitled' }}
42+
{{ getVersionItemDisplayName(versionItem) }}
4343
</a>
4444
</ng-container>
4545
</ng-template>
4646
<ng-template #itemNameWithoutLink>
4747
<ng-container *ngIf="(versionDTO.version.item | async)?.payload as versionItem">
48-
{{ versionItem.firstMetadataValue('dc.title') || versionItem.name || 'Untitled' }}
48+
{{ getVersionItemDisplayName(versionItem) }}
4949
</ng-container>
5050
</ng-template>
5151
<span *ngIf="versionDTO.version.id === itemVersion?.id">*</span>
@@ -102,7 +102,7 @@ <h4 class="mb-0 me-2">{{ "item.version.history.head" | translate }}</h4>
102102
<div>*&nbsp;{{ "item.version.history.selected" | translate }}</div>
103103
</ds-pagination>
104104
</div>
105-
105+
106106
</div>
107107
</div>
108108
<ng-template #noItemVersion>

src/app/item-page/versions/item-versions.component.ts

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -586,6 +586,14 @@ export class ItemVersionsComponent implements OnDestroy, OnInit {
586586
map((item: Item) => this.dsoNameService.getName(item)));
587587
}
588588

589+
/**
590+
* Get the display name for a version item
591+
* @param versionItem the item to get the name for
592+
*/
593+
getVersionItemDisplayName(versionItem: Item): string {
594+
return versionItem.firstMetadataValue('dc.title') || versionItem.name || 'Untitled';
595+
}
596+
589597
getItemHandleFromVersion(version: Version) {
590598
return version.item
591599
.pipe(

0 commit comments

Comments
 (0)