Port #1291 to dtq-dev-9-base: UFAL/Updated components to display dc.description instead of dc.description.abstract (#1291) (#1501)

The search result list and grid elements read the item description from
dc.description.abstract. LINDAT items carry their description in dc.description,
so both views rendered nothing where the description belongs.

Both templates now read dc.description in the guard and in the binding (4
substitutions across the two files). The trade-off is deliberate and was made in
#1291: an item that only has dc.description.abstract now shows no description in
these two views. The two new negative specs pin exactly that, so the trade-off
cannot be undone by accident.

- item-search-result-grid-element.component.html / .spec.ts: the @if guard and the
  [innerHTML] binding switch key; mockItemWithAbstractOnly is added and passed as a
  new 5th argument to getEntityGridElementTestComponent. That parameter is optional,
  so the six entity-group grid specs that call the helper with four arguments
  (journal, journal-issue, journal-volume, org-unit, person, project) keep compiling
  unchanged.
- item-search-result-list-element.component.html / .spec.ts: same key switch plus a
  mockItemWithAbstractOnly and a negative describe block.

v9 notes: the source hunks are *ngIf; both templates on this branch have already
been migrated to @if, so the guards were adapted in place - same condition, same
two metadata keys per file. The list spec uses `of` where the source uses
`observableOf`, and the new mocks follow this branch's trailing-comma style. The
custom theme's item-search-result-list-element reuses the base templateUrl, so no
theme override needed changing; the grid element has no theme override.

Card PB-05 (tranche T3).

Source: 3a95a85 (dtq-dev PR #1291)

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>

Author: milanmajchrak

src/app/shared/object-grid/search-result-grid-element/item-search-result/item/item-search-result-grid-element.component.html

@@ -41,10 +41,10 @@ <h4 class="card-title" [innerHTML]="dsoTitle"></h4>
           </p>
         </ds-truncatable-part>
       }
-      @if (dso.hasMetadata('dc.description.abstract')) {
+      @if (dso.hasMetadata('dc.description')) {
         <ds-truncatable-part [id]="dso.id" [minLines]="3">
           <p class="item-abstract card-text">
-            <span [innerHTML]="firstMetadataValue('dc.description.abstract')"></span>
+            <span [innerHTML]="firstMetadataValue('dc.description')"></span>
           </p>
         </ds-truncatable-part>
       }

src/app/shared/object-grid/search-result-grid-element/item-search-result/item/item-search-result-grid-element.component.spec.ts

@@ -73,14 +73,33 @@ mockItemWithMetadata.indexableObject = Object.assign(new Item(), {
         value: '2015-06-26',
       },
     ],
-    'dc.description.abstract': [
+    'dc.description': [
       {
         language: 'en_US',
         value: 'This is an abstract',
       },
     ],
   },
 });
+const mockItemWithAbstractOnly: ItemSearchResult = new ItemSearchResult();
+mockItemWithAbstractOnly.hitHighlights = {};
+mockItemWithAbstractOnly.indexableObject = Object.assign(new Item(), {
+  bundles: createSuccessfulRemoteDataObject$(buildPaginatedList(new PageInfo(), [])),
+  metadata: {
+    'dc.title': [
+      {
+        language: 'en_US',
+        value: dcTitle,
+      },
+    ],
+    'dc.description.abstract': [
+      {
+        language: 'en_US',
+        value: 'Legacy abstract only',
+      },
+    ],
+  },
+});
 const mockPerson: ItemSearchResult = Object.assign(new ItemSearchResult(), {
   hitHighlights: {
     'person.familyName': [{
@@ -116,7 +135,7 @@ const mockPerson: ItemSearchResult = Object.assign(new ItemSearchResult(), {
             value: '2015-06-26',
           },
         ],
-        'dc.description.abstract': [
+        'dc.description': [
           {
             language: 'en_US',
             value: 'This is the abstract',
@@ -170,7 +189,7 @@ const mockOrgUnit: ItemSearchResult = Object.assign(new ItemSearchResult(), {
             value: '2015-06-26',
           },
         ],
-        'dc.description.abstract': [
+        'dc.description': [
           {
             language: 'en_US',
             value: 'This is the abstract',
@@ -204,7 +223,7 @@ mockItemWithoutMetadata.indexableObject = Object.assign(new Item(), {
   },
 });
 
-describe('ItemGridElementComponent', getEntityGridElementTestComponent(ItemSearchResultGridElementComponent, mockItemWithMetadata, mockItemWithoutMetadata, ['authors', 'date', 'abstract']));
+describe('ItemGridElementComponent', getEntityGridElementTestComponent(ItemSearchResultGridElementComponent, mockItemWithMetadata, mockItemWithoutMetadata, ['authors', 'date', 'abstract'], mockItemWithAbstractOnly));
 
 /**
  * Create test cases for a grid component of an entity.
@@ -215,7 +234,13 @@ describe('ItemGridElementComponent', getEntityGridElementTestComponent(ItemSearc
  *                                      For example: If one of the fields to check is labeled "authors", the html template should contain at least one element with class ".item-authors" that's
  *                                      present when the author metadata is available.
  */
-export function getEntityGridElementTestComponent(component, searchResultWithMetadata: ItemSearchResult, searchResultWithoutMetadata: ItemSearchResult, fieldsToCheck: string[]) {
+export function getEntityGridElementTestComponent(
+  component,
+  searchResultWithMetadata: ItemSearchResult,
+  searchResultWithoutMetadata: ItemSearchResult,
+  fieldsToCheck: string[],
+  searchResultWithAbstractOnly?: ItemSearchResult,
+) {
   return () => {
     let comp;
     let fixture;
@@ -269,6 +294,20 @@ export function getEntityGridElementTestComponent(component, searchResultWithMet
       comp = fixture.componentInstance;
     }));
 
+    if (searchResultWithAbstractOnly) {
+      describe('when the item has only dc.description.abstract metadata', () => {
+        beforeEach(() => {
+          comp.object = searchResultWithAbstractOnly;
+          fixture.detectChanges();
+        });
+
+        it('should not show abstract field', () => {
+          const abstractField = fixture.debugElement.query(By.css('.item-abstract'));
+          expect(abstractField).toBeNull();
+        });
+      });
+    }
+
     fieldsToCheck.forEach((field) => {
       describe(`when the item has "${field}" metadata`, () => {
         beforeEach(() => {

src/app/shared/object-list/search-result-list-element/item-search-result/item-types/item/item-search-result-list-element.component.html

@@ -61,10 +61,10 @@
             }
           </ds-truncatable-part>
         </span>
-        @if (dso.firstMetadataValue('dc.description.abstract')) {
+        @if (dso.firstMetadataValue('dc.description')) {
           <div class="item-list-abstract">
             <ds-truncatable-part [id]="dso.id" [minLines]="3"><span
-            [innerHTML]="firstMetadataValue('dc.description.abstract')"></span>
+            [innerHTML]="firstMetadataValue('dc.description')"></span>
           </ds-truncatable-part>
         </div>
       }

src/app/shared/object-list/search-result-list-element/item-search-result/item-types/item/item-search-result-list-element.component.spec.ts

@@ -68,7 +68,7 @@ const mockItemWithMetadata: ItemSearchResult = Object.assign(new ItemSearchResul
             value: '2015-06-26',
           },
         ],
-        'dc.description.abstract': [
+        'dc.description': [
           {
             language: 'en_US',
             value: 'This is the abstract',
@@ -77,6 +77,20 @@ const mockItemWithMetadata: ItemSearchResult = Object.assign(new ItemSearchResul
       },
     }),
 });
+const mockItemWithAbstractOnly: ItemSearchResult = Object.assign(new ItemSearchResult(), {
+  indexableObject:
+    Object.assign(new Item(), {
+      bundles: of({}),
+      metadata: {
+        'dc.description.abstract': [
+          {
+            language: 'en_US',
+            value: 'Legacy abstract only',
+          },
+        ],
+      },
+    }),
+});
 const mockItemWithoutMetadata: ItemSearchResult = Object.assign(new ItemSearchResult(), {
   indexableObject:
     Object.assign(new Item(), {
@@ -119,7 +133,7 @@ const mockPerson: ItemSearchResult = Object.assign(new ItemSearchResult(), {
             value: '2015-06-26',
           },
         ],
-        'dc.description.abstract': [
+        'dc.description': [
           {
             language: 'en_US',
             value: 'This is the abstract',
@@ -173,7 +187,7 @@ const mockOrgUnit: ItemSearchResult = Object.assign(new ItemSearchResult(), {
             value: '2015-06-26',
           },
         ],
-        'dc.description.abstract': [
+        'dc.description': [
           {
             language: 'en_US',
             value: 'This is the abstract',
@@ -349,6 +363,18 @@ describe('ItemSearchResultListElementComponent', () => {
     });
   });
 
+  describe('When the item has only dc.description.abstract metadata', () => {
+    beforeEach(() => {
+      publicationListElementComponent.object = mockItemWithAbstractOnly;
+      fixture.detectChanges();
+    });
+
+    it('should not show the abstract span', () => {
+      const abstractField = fixture.debugElement.query(By.css('div.item-list-abstract'));
+      expect(abstractField).toBeNull();
+    });
+  });
+
   describe('When the item has title', () => {
     beforeEach(() => {
       publicationListElementComponent.object = mockItemWithMetadata;