|
| 1 | +import { |
| 2 | + fakeAsync, |
| 3 | + TestBed, |
| 4 | + tick, |
| 5 | +} from '@angular/core/testing'; |
| 6 | +import { TranslateService } from '@ngx-translate/core'; |
| 7 | +import { |
| 8 | + of, |
| 9 | + throwError as observableThrowError, |
| 10 | +} from 'rxjs'; |
| 11 | + |
| 12 | +import { AuthorizationDataService } from '../../core/data/feature-authorization/authorization-data.service'; |
| 13 | +import { FeatureID } from '../../core/data/feature-authorization/feature-id'; |
| 14 | +import { buildPaginatedList } from '../../core/data/paginated-list.model'; |
| 15 | +import { DSpaceObject } from '../../core/shared/dspace-object.model'; |
| 16 | +import { PageInfo } from '../../core/shared/page-info.model'; |
| 17 | +import { SearchService } from '../../core/shared/search/search.service'; |
| 18 | +import { WorkflowItemDataService } from '../../core/submission/workflowitem-data.service'; |
| 19 | +import { WorkspaceitemDataService } from '../../core/submission/workspaceitem-data.service'; |
| 20 | +import { NotificationsService } from '../../shared/notifications/notifications.service'; |
| 21 | +import { |
| 22 | + createFailedRemoteDataObject$, |
| 23 | + createSuccessfulRemoteDataObject$, |
| 24 | +} from '../../shared/remote-data.utils'; |
| 25 | +import { SearchObjects } from '../../shared/search/models/search-objects.model'; |
| 26 | +import { EPersonMock } from '../../shared/testing/eperson.mock'; |
| 27 | +import { NotificationsServiceStub } from '../../shared/testing/notifications-service.stub'; |
| 28 | +import { EPersonDeleteGuardService } from './eperson-delete-guard.service'; |
| 29 | + |
| 30 | +describe('EPersonDeleteGuardService', () => { |
| 31 | + let service: EPersonDeleteGuardService; |
| 32 | + let authorizationService: jasmine.SpyObj<AuthorizationDataService>; |
| 33 | + let workspaceItemDataService: jasmine.SpyObj<WorkspaceitemDataService>; |
| 34 | + let workflowItemDataService: jasmine.SpyObj<WorkflowItemDataService>; |
| 35 | + let searchService: jasmine.SpyObj<SearchService>; |
| 36 | + let notificationsService: NotificationsServiceStub; |
| 37 | + let translateService: jasmine.SpyObj<TranslateService>; |
| 38 | + |
| 39 | + const remoteList = (totalElements: number) => createSuccessfulRemoteDataObject$( |
| 40 | + buildPaginatedList(new PageInfo({ elementsPerPage: 1, totalElements, totalPages: 1, currentPage: 1 }), []), |
| 41 | + ); |
| 42 | + const searchObjects = (totalElements: number) => createSuccessfulRemoteDataObject$(Object.assign( |
| 43 | + new SearchObjects<DSpaceObject>(), |
| 44 | + buildPaginatedList(new PageInfo({ elementsPerPage: 1, totalElements, totalPages: 1, currentPage: 1 }), []), |
| 45 | + )); |
| 46 | + |
| 47 | + beforeEach(() => { |
| 48 | + authorizationService = jasmine.createSpyObj('authorizationService', ['isAuthorized']); |
| 49 | + authorizationService.isAuthorized.and.returnValue(of(false)); |
| 50 | + workspaceItemDataService = jasmine.createSpyObj('workspaceItemDataService', ['searchBy']); |
| 51 | + workspaceItemDataService.searchBy.and.returnValue(remoteList(0)); |
| 52 | + workflowItemDataService = jasmine.createSpyObj('workflowItemDataService', ['searchBy']); |
| 53 | + workflowItemDataService.searchBy.and.returnValue(remoteList(0)); |
| 54 | + searchService = jasmine.createSpyObj('searchService', ['search']); |
| 55 | + searchService.search.and.returnValue(searchObjects(0)); |
| 56 | + notificationsService = new NotificationsServiceStub(); |
| 57 | + translateService = jasmine.createSpyObj('translateService', ['get']); |
| 58 | + translateService.get.and.callFake((key: string) => of(key)); |
| 59 | + |
| 60 | + TestBed.configureTestingModule({ |
| 61 | + providers: [ |
| 62 | + EPersonDeleteGuardService, |
| 63 | + { provide: AuthorizationDataService, useValue: authorizationService }, |
| 64 | + { provide: WorkspaceitemDataService, useValue: workspaceItemDataService }, |
| 65 | + { provide: WorkflowItemDataService, useValue: workflowItemDataService }, |
| 66 | + { provide: SearchService, useValue: searchService }, |
| 67 | + { provide: NotificationsService, useValue: notificationsService }, |
| 68 | + { provide: TranslateService, useValue: translateService }, |
| 69 | + ], |
| 70 | + }); |
| 71 | + service = TestBed.inject(EPersonDeleteGuardService); |
| 72 | + }); |
| 73 | + |
| 74 | + describe('isCurrentUser', () => { |
| 75 | + it('is true only when the ids match', () => { |
| 76 | + expect(service.isCurrentUser(EPersonMock, EPersonMock.id)).toBeTrue(); |
| 77 | + expect(service.isCurrentUser(EPersonMock, 'someone-else')).toBeFalse(); |
| 78 | + expect(service.isCurrentUser(undefined, EPersonMock.id)).toBeFalsy(); |
| 79 | + }); |
| 80 | + }); |
| 81 | + |
| 82 | + describe('getDeleteWarningLabel', () => { |
| 83 | + it('returns undefined when the user is neither a submitter nor an admin', fakeAsync(() => { |
| 84 | + let label: string | undefined = 'unset'; |
| 85 | + service.getDeleteWarningLabel(EPersonMock).subscribe((value) => label = value); |
| 86 | + tick(); |
| 87 | + expect(label).toBeUndefined(); |
| 88 | + })); |
| 89 | + |
| 90 | + it('returns the submitter warning when the user has submitted items', fakeAsync(() => { |
| 91 | + workspaceItemDataService.searchBy.and.returnValue(remoteList(1)); |
| 92 | + let label: string; |
| 93 | + service.getDeleteWarningLabel(EPersonMock).subscribe((value) => label = value); |
| 94 | + tick(); |
| 95 | + expect(label).toBe('admin.access-control.epeople.delete.warning.submitter'); |
| 96 | + })); |
| 97 | + |
| 98 | + it('returns the admin warning, querying the AdministratorOf feature for the target user', fakeAsync(() => { |
| 99 | + authorizationService.isAuthorized.and.returnValue(of(true)); |
| 100 | + let label: string; |
| 101 | + service.getDeleteWarningLabel(EPersonMock).subscribe((value) => label = value); |
| 102 | + tick(); |
| 103 | + expect(authorizationService.isAuthorized).toHaveBeenCalledWith(FeatureID.AdministratorOf, undefined, EPersonMock.id); |
| 104 | + expect(label).toBe('admin.access-control.epeople.delete.warning.admin'); |
| 105 | + })); |
| 106 | + |
| 107 | + it('returns the combined warning when both apply', fakeAsync(() => { |
| 108 | + workspaceItemDataService.searchBy.and.returnValue(remoteList(1)); |
| 109 | + authorizationService.isAuthorized.and.returnValue(of(true)); |
| 110 | + let label: string; |
| 111 | + service.getDeleteWarningLabel(EPersonMock).subscribe((value) => label = value); |
| 112 | + tick(); |
| 113 | + expect(label).toBe('admin.access-control.epeople.delete.warning.submitterAndAdmin'); |
| 114 | + })); |
| 115 | + |
| 116 | + it('degrades each probe to false on error so a failed lookup never blocks the delete', fakeAsync(() => { |
| 117 | + workspaceItemDataService.searchBy.and.returnValue(observableThrowError(() => new Error('boom'))); |
| 118 | + searchService.search.and.returnValue(observableThrowError(() => new Error('boom'))); |
| 119 | + authorizationService.isAuthorized.and.returnValue(observableThrowError(() => new Error('boom'))); |
| 120 | + let emitted = false; |
| 121 | + let label: string | undefined = 'unset'; |
| 122 | + service.getDeleteWarningLabel(EPersonMock).subscribe((value) => { |
| 123 | + emitted = true; |
| 124 | + label = value; |
| 125 | + }); |
| 126 | + tick(); |
| 127 | + expect(emitted).toBeTrue(); |
| 128 | + expect(label).toBeUndefined(); |
| 129 | + })); |
| 130 | + }); |
| 131 | + |
| 132 | + describe('isSelfDeletionError', () => { |
| 133 | + it('recognises the backend self-delete rejection', fakeAsync(() => { |
| 134 | + let rd; |
| 135 | + createFailedRemoteDataObject$('You, as admin user, cannot delete yourself', 400).subscribe((value) => rd = value); |
| 136 | + tick(); |
| 137 | + expect(service.isSelfDeletionError(rd)).toBeTrue(); |
| 138 | + })); |
| 139 | + |
| 140 | + it('ignores other failures', fakeAsync(() => { |
| 141 | + let rd; |
| 142 | + createFailedRemoteDataObject$('server error', 500).subscribe((value) => rd = value); |
| 143 | + tick(); |
| 144 | + expect(service.isSelfDeletionError(rd)).toBeFalsy(); |
| 145 | + expect(service.isSelfDeletionError(null)).toBeFalsy(); |
| 146 | + })); |
| 147 | + }); |
| 148 | + |
| 149 | + describe('showSelfDeleteNotification', () => { |
| 150 | + it('emits the self-delete error notification', () => { |
| 151 | + service.showSelfDeleteNotification(); |
| 152 | + expect(notificationsService.error).toHaveBeenCalled(); |
| 153 | + let translatedKey: string; |
| 154 | + notificationsService.error.calls.mostRecent().args[0].subscribe((value) => translatedKey = value); |
| 155 | + expect(translatedKey).toBe('admin.access-control.epeople.notification.deleted.forbidden.self'); |
| 156 | + }); |
| 157 | + }); |
| 158 | +}); |
0 commit comments