Port #1326 to dtq-dev-9-base: Add search icon to community and collection

The DSO action menu of a Community or Collection gains a scoped-search entry
that opens /search restricted to that container, on the first page
(/search?spc.page=1&scope=<uuid>).

This is a rewrite, not a translation. On 7.x the entry was one more object in
the array returned by DSOEditMenuResolver (`id: 'search-dso'`, `index: 3`).
That resolver does not exist on v9 - the DSO edit menu is assembled from menu
providers registered in app.menus.ts - so the port is:

* new `ComColSearchMenuProvider extends DSpaceObjectPageMenuProvider`, modelled
  on the sibling `comcol-subscribe.menu.ts`, returning one LINK section
  { text: 'search.title', link: '/search',
    queryParams: { 'spc.page': '1', scope: dso.uuid }, icon: 'search' };
* registered FIRST inside `DsoOptionMenuProvider.withSubs([...])` with
  `.onRoute(MenuRoute.COMMUNITY_PAGE, MenuRoute.COLLECTION_PAGE)` - ordering on
  v9 comes from the position in withSubs([...]), which is why 7.x's `index: 3`
  is dropped rather than translated. `id: 'search-dso'` and `active: false` are
  dropped for the same reason: `PartialMenuSection.id` is optional and
  auto-assigned, and no sibling provider sets either;
* `[queryParams]="itemModel.queryParams"` added to the LINK anchor in
  dso-edit-menu-section.component.html. `LinkMenuItemModel.queryParams` already
  exists on 9-base (vanilla) but the DSO-edit renderer silently dropped it, so
  this one line is what makes the model half work.

The 7.x resolver-spec hunks have no target on v9 and are replaced by the new
provider spec (2 cases). The two page specs the source commit also adds
(community-page / collection-page) are deliberately NOT ported: they do not
exist on 9-base or on dspace-9.3, they are written pre-standalone, and their
single assertion is `expect(query(By.css('ds-dso-edit-menu'))).toBeTruthy()`,
which does not exercise this feature at all.

UX note, decided by the repository owner (decision O-4): on v9 every DSO_EDIT
sub-provider is nested under DsoOptionMenuProvider, so the magnifier is an entry
inside the "options" dropdown rather than a button next to Subscribe/Edit. The
new section is visible unconditionally (a scoped search was public on 7.x too),
which flips `hasSubSections$` from false to true for anonymous visitors and
therefore makes the "options" button itself visible to them for the first time.
That is accepted: the feature is unchanged, only the chrome around it is new.

Source: fecfa07 (dtq-dev PR #1326)

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

Author: milanmajchrak

src/app/app.menus.ts

@@ -13,6 +13,7 @@ import { AdminSearchMenuProvider } from './shared/menu/providers/admin-search.me
 import { BrowseMenuProvider } from './shared/menu/providers/browse.menu';
 import { ClarinAdminMenuProvider } from './shared/menu/providers/clarin-admin.menu';
 import { CoarNotifyMenuProvider } from './shared/menu/providers/coar-notify.menu';
+import { ComColSearchMenuProvider } from './shared/menu/providers/comcol-search.menu';
 import { SubscribeMenuProvider } from './shared/menu/providers/comcol-subscribe.menu';
 import { CommunityListMenuProvider } from './shared/menu/providers/community-list.menu';
 import { CreateReportMenuProvider } from './shared/menu/providers/create-report.menu';
@@ -81,6 +82,11 @@ export const MENUS = buildMenuStructure({
   ],
   [MenuID.DSO_EDIT]: [
     DsoOptionMenuProvider.withSubs([
+      // CLARIN/LINDAT: scoped search on the container's own page
+      ComColSearchMenuProvider.onRoute(
+        MenuRoute.COMMUNITY_PAGE,
+        MenuRoute.COLLECTION_PAGE,
+      ),
       SubscribeMenuProvider.onRoute(
         MenuRoute.COMMUNITY_PAGE,
         MenuRoute.COLLECTION_PAGE,

src/app/shared/dso-page/dso-edit-menu/dso-edit-menu-section/dso-edit-menu-section.component.html

@@ -3,7 +3,8 @@
     [ngbTooltip]="itemModel.text | translate">
     @if (!section.model.disabled) {
       <a class="btn btn-dark btn-sm"
-        [routerLink]="itemModel.link">
+        [routerLink]="itemModel.link"
+        [queryParams]="itemModel.queryParams">
         <i class="fas fa-{{section.icon}} fa-fw" aria-hidden="true"></i>
         <span class="sr-only">{{itemModel.text | translate}}</span>
       </a>

src/app/shared/dso-page/dso-edit-menu/dso-edit-menu-section/dso-edit-menu-section.component.spec.ts

@@ -8,6 +8,7 @@ import { By } from '@angular/platform-browser';
 import {
   ActivatedRoute,
   Router,
+  RouterLink,
 } from '@angular/router';
 import { TranslateModule } from '@ngx-translate/core';
 import { of } from 'rxjs';
@@ -73,6 +74,9 @@ describe('DsoEditMenuSectionComponent', () => {
       disabled: false,
       text: 'text',
       link: 'link',
+      queryParams: {
+        scope: 'test-scope-id',
+      },
     },
     icon: iconString,
   };
@@ -173,6 +177,15 @@ describe('DsoEditMenuSectionComponent', () => {
       expect(fixture.debugElement.query(By.css('a'))).not.toBeNull();
     });
 
+    it('should bind queryParams on the link element', () => {
+      const link = fixture.debugElement.query(By.css('a'));
+
+      // v9: RouterLink is a standalone directive, so its inputs are no longer mirrored into
+      // DebugElement.properties (that map is the raw DOM element on Angular 20) - read the
+      // directive instance instead, which is what the 7.x `link.properties.queryParams` meant.
+      expect(link.injector.get(RouterLink).queryParams).toEqual({ scope: 'test-scope-id' });
+    });
+
   });
 });
 

src/app/shared/menu/providers/comcol-search.menu.spec.ts

@@ -0,0 +1,50 @@
+import { TestBed } from '@angular/core/testing';
+
+import { Collection } from '../../../core/shared/collection.model';
+import { Community } from '../../../core/shared/community.model';
+import { LinkMenuItemModel } from '../menu-item/models/link.model';
+import { MenuItemType } from '../menu-item-type.model';
+import { ComColSearchMenuProvider } from './comcol-search.menu';
+
+describe('ComColSearchMenuProvider', () => {
+
+  let provider: ComColSearchMenuProvider;
+
+  const community: Community = Object.assign(new Community(), { uuid: 'test-community-uuid' });
+  const collection: Collection = Object.assign(new Collection(), { uuid: 'test-collection-uuid' });
+
+  beforeEach(() => {
+    TestBed.configureTestingModule({
+      providers: [
+        ComColSearchMenuProvider,
+      ],
+    });
+    provider = TestBed.inject(ComColSearchMenuProvider);
+  });
+
+  describe('getSectionsForContext', () => {
+    it('should return a single visible scoped-search link section for a community', (done) => {
+      provider.getSectionsForContext(community).subscribe((sections) => {
+        expect(sections.length).toEqual(1);
+        expect(sections[0].visible).toBeTrue();
+        expect(sections[0].icon).toEqual('search');
+        expect(sections[0].model.type).toEqual(MenuItemType.LINK);
+        expect((sections[0].model as LinkMenuItemModel).text).toEqual('search.title');
+        expect((sections[0].model as LinkMenuItemModel).link).toEqual('/search');
+        expect((sections[0].model as LinkMenuItemModel).queryParams['spc.page']).toEqual('1');
+        expect((sections[0].model as LinkMenuItemModel).queryParams.scope).toEqual('test-community-uuid');
+        done();
+      });
+    });
+
+    it('should scope the search to the collection uuid when the context is a collection', (done) => {
+      provider.getSectionsForContext(collection).subscribe((sections) => {
+        expect(sections.length).toEqual(1);
+        expect(sections[0].visible).toBeTrue();
+        expect((sections[0].model as LinkMenuItemModel).queryParams.scope).toEqual('test-collection-uuid');
+        done();
+      });
+    });
+  });
+
+});

src/app/shared/menu/providers/comcol-search.menu.ts

@@ -0,0 +1,48 @@
+/**
+ * The contents of this file are subject to the license and copyright
+ * detailed in the LICENSE and NOTICE files at the root of the source
+ * tree and available online at
+ *
+ * http://www.dspace.org/license/
+ */
+import { Injectable } from '@angular/core';
+import {
+  Observable,
+  of,
+} from 'rxjs';
+
+import { DSpaceObject } from '../../../core/shared/dspace-object.model';
+import { LinkMenuItemModel } from '../menu-item/models/link.model';
+import { MenuItemType } from '../menu-item-type.model';
+import { PartialMenuSection } from '../menu-provider.model';
+import { DSpaceObjectPageMenuProvider } from './helper-providers/dso.menu';
+
+/**
+ * CLARIN/LINDAT: menu provider to create the scoped-search option in the DSO edit menu of a
+ * Community or Collection. It opens /search restricted to that container, on the first page.
+ *
+ * The section is visible unconditionally - a scoped search is a public action, exactly as it was on
+ * 7.x, where the same entry was added by DSOEditMenuResolver without an authorization check.
+ */
+@Injectable()
+export class ComColSearchMenuProvider extends DSpaceObjectPageMenuProvider {
+
+  public getSectionsForContext(dso: DSpaceObject): Observable<PartialMenuSection[]> {
+    return of([
+      {
+        visible: true,
+        model: {
+          type: MenuItemType.LINK,
+          disabled: false,
+          text: 'search.title',
+          link: '/search',
+          queryParams: {
+            'spc.page': '1',
+            scope: dso.uuid,
+          },
+        } as LinkMenuItemModel,
+        icon: 'search',
+      },
+    ] as PartialMenuSection[]);
+  }
+}