Commit 97a5c89
JCU/Reduce the footer vendor credit to the company name (#1470)
* JCU/Reduce the footer vendor credit to the company name
The footer credit read "· Theme by + dataquest" at the end of the copyright
line. Drop the wording and leave the company name on its own, so the line
reads "DSpace software copyright © 2002-2026 LYRASIS · + dataquest".
The wording was hard-coded in the template here, not translated, so there
is no i18n key to remove. The @if guard on the company name and the [href]
fallback are both untouched.
Refs dataquest-dev/dspace-customers#592
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
* JCU/Move the vendor credit out of the copyright line
Review feedback: the credit should stand on its own at the right end of the
bar, the way it does on the ZCU and VSB-TUO instances, rather than trailing
the copyright sentence.
The credit was a <span> inside the copyright <p>, separated by a middot.
It is now its own element, a sibling of .content-container, pinned to the
right edge of .bottom-footer on md and up. The middot goes with it — it was
only there to join two things sharing a line.
.bottom-footer gains position: relative as the anchor. No COAR block renders
on this instance, so this does not move .notify-enabled, which uses the same
absolute-right pattern this rule follows.
Below md the bar is a flex column, so the credit simply stacks under the
content as the rest of the footer does.
Refs dataquest-dev/dspace-customers#592
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
* JCU/Space the vendor credit off the copyright block and drop its underline
Review feedback on the previous commit: pinning the credit to the right edge
of the bar put it flush against the border. Replace the absolute positioning
with a plain flex gap, matching how ZCU and VSB-TUO lay theirs out, and widen
it to 16rem so the credit reads as separate from the centred block.
Dropping absolute positioning also removes the need for position: relative on
.bottom-footer, so .notify-enabled keeps its original anchor and the two can
no longer end up in the same corner.
Also drop text-decoration-underline from the credit link. It made sense while
the credit trailed the copyright sentence and needed to look like a link
inside running text; standing on its own it read as a button. The anchor is
otherwise untouched — href, target, rel and role all stay — and this brings
JCU in line with the other customers, none of which underline the credit.
Refs dataquest-dev/dspace-customers#592
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
* JCU/Drop other customers' names from the footer comment
Review feedback: the SCSS comment explaining the credit's layout named two
other customer instances. That reference has no business shipping inside a
customer's own source tree, and it does not help anyone reading this file.
The explanation of what the rule does and why it avoids absolute positioning
stays; only the cross-customer reference is gone.
Refs dataquest-dev/dspace-customers#592
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5 <noreply@anthropic.com>1 parent 73ba21c commit 97a5c89
2 files changed
Lines changed: 16 additions & 6 deletions
File tree
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
57 | 57 | | |
58 | 58 | | |
59 | 59 | | |
60 | | - | |
61 | | - | |
62 | | - | |
63 | | - | |
64 | | - | |
65 | | - | |
66 | 60 | | |
67 | 61 | | |
68 | 62 | | |
| |||
96 | 90 | | |
97 | 91 | | |
98 | 92 | | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
99 | 99 | | |
100 | 100 | | |
101 | 101 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
25 | 35 | | |
26 | 36 | | |
27 | 37 | | |
| |||
0 commit comments