Skip to content

Commit 97a5c89

Browse files
MatusBekeclaude
andauthored
JCU/Reduce the footer vendor credit to the company name (#1470)
* JCU/Reduce the footer vendor credit to the company name The footer credit read "· Theme by + dataquest" at the end of the copyright line. Drop the wording and leave the company name on its own, so the line reads "DSpace software copyright © 2002-2026 LYRASIS · + dataquest". The wording was hard-coded in the template here, not translated, so there is no i18n key to remove. The @if guard on the company name and the [href] fallback are both untouched. Refs dataquest-dev/dspace-customers#592 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * JCU/Move the vendor credit out of the copyright line Review feedback: the credit should stand on its own at the right end of the bar, the way it does on the ZCU and VSB-TUO instances, rather than trailing the copyright sentence. The credit was a <span> inside the copyright <p>, separated by a middot. It is now its own element, a sibling of .content-container, pinned to the right edge of .bottom-footer on md and up. The middot goes with it — it was only there to join two things sharing a line. .bottom-footer gains position: relative as the anchor. No COAR block renders on this instance, so this does not move .notify-enabled, which uses the same absolute-right pattern this rule follows. Below md the bar is a flex column, so the credit simply stacks under the content as the rest of the footer does. Refs dataquest-dev/dspace-customers#592 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * JCU/Space the vendor credit off the copyright block and drop its underline Review feedback on the previous commit: pinning the credit to the right edge of the bar put it flush against the border. Replace the absolute positioning with a plain flex gap, matching how ZCU and VSB-TUO lay theirs out, and widen it to 16rem so the credit reads as separate from the centred block. Dropping absolute positioning also removes the need for position: relative on .bottom-footer, so .notify-enabled keeps its original anchor and the two can no longer end up in the same corner. Also drop text-decoration-underline from the credit link. It made sense while the credit trailed the copyright sentence and needed to look like a link inside running text; standing on its own it read as a button. The anchor is otherwise untouched — href, target, rel and role all stay — and this brings JCU in line with the other customers, none of which underline the credit. Refs dataquest-dev/dspace-customers#592 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * JCU/Drop other customers' names from the footer comment Review feedback: the SCSS comment explaining the credit's layout named two other customer instances. That reference has no business shipping inside a customer's own source tree, and it does not help anyone reading this file. The explanation of what the rule does and why it avoids absolute positioning stays; only the cross-customer reference is gone. Refs dataquest-dev/dspace-customers#592 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
1 parent 73ba21c commit 97a5c89

2 files changed

Lines changed: 16 additions & 6 deletions

File tree

src/app/footer/footer.component.html

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -57,12 +57,6 @@ <h5 class="text-uppercase">Footer Content</h5>
5757
{{ 'footer.copyright' | translate:{year: dateObj | date:'y'} }}
5858
<a class="text-white"
5959
href="https://www.lyrasis.org/" role="link" tabindex="0">{{ 'footer.link.lyrasis' | translate}}</a>
60-
@if ((themedByCompanyName$ | async)?.payload?.values?.[0]; as themedByCompany) {
61-
<span class="ms-2">&middot;&nbsp;Theme by
62-
<a class="text-white text-decoration-underline"
63-
[href]="((themedByUrl$ | async)?.payload?.values)?.[0] || '#'" target="_blank" rel="noopener noreferrer" role="link">{{ themedByCompany }}</a>
64-
</span>
65-
}
6660
</p>
6761
<ul class="footer-info list-unstyled d-flex flex-wrap justify-content-center mb-0">
6862
@if (showCookieSettings) {
@@ -96,6 +90,12 @@ <h5 class="text-uppercase">Footer Content</h5>
9690
}
9791
</ul>
9892
</div>
93+
@if ((themedByCompanyName$ | async)?.payload?.values?.[0]; as themedByCompany) {
94+
<div class="footer-sign">
95+
<a class="text-white"
96+
[href]="((themedByUrl$ | async)?.payload?.values)?.[0] || '#'" target="_blank" rel="noopener noreferrer" role="link">{{ themedByCompany }}</a>
97+
</div>
98+
}
9999
@if (coarLdnEnabled$ | async) {
100100
<div class="notify-enabled text-white align-self-end">
101101
<a class="coar-notify-support-route" routerLink="info/coar-notify-support" role="link" tabindex="0">

src/app/footer/footer.component.scss

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,16 @@
2222
}
2323

2424
.bottom-footer {
25+
// Vendor credit stands on its own to the right of the centred copyright
26+
// block. A plain flex item with a wide gap rather than absolute
27+
// positioning, so it never overlaps the .notify-enabled block that pins
28+
// itself bottom-right.
29+
.footer-sign {
30+
@media screen and (min-width: map-get($grid-breakpoints, md)) {
31+
margin-left: 16rem;
32+
}
33+
}
34+
2535
.notify-enabled {
2636
position: relative;
2737
margin-top: 4px;

0 commit comments

Comments
 (0)