MENDELU/Fixed integration tests (#1294)

* Fix a11y link-name on thumbnail anchors in search-result list elements

* fix(metadata-link): cache resolver config permanently to stabilize /full item-page render

MetadataLinkService is a singleton (providedIn: root) that fetches 5 backend
configuration properties in parallel via combineLatest. The template on the
full item page subscribes to it via async pipes inside an @for loop over
metadata entries; subscriber count fluctuates as rows render, and with
shareReplay({ refCount: true }) the inner subscription was torn down and
re-created repeatedly, causing the 5 HTTP calls to repeat and the metadata
table to render slowly or inconsistently on Cypress CI runners.

- Switch shareReplay to refCount: false so resolver values are cached for
  the lifetime of the service.
- Eagerly subscribe in the constructor so the fetches start as soon as the
  service is created (during the first FullItemPageComponent instantiation),
  warming the replay buffer before template subscriptions run.

* Revert "fix(metadata-link): cache resolver config permanently to stabilize /full item-page render"

This reverts commit 3b852c4.

* fix(a11y): satisfy aria-required-children on edit-item tablist and wait for inner content before axe checks

- edit-item-page tablist had disabled <button> children without role=tab; when all tabs start with enabled|async = false the <ul role=tablist> momentarily has no role=tab children, triggering aria-required-children. Add role=tab + aria-disabled=true + aria-selected=false + tabindex=-1 to the disabled button so the tablist always has valid children.

- For 4 axe checks that failed with 'No elements found for include in page Context' on CI runners (collection delete, community delete, item-edit status, item /full), wait for a stable inner element to render before calling testA11y; the host element passes :visible due to its padding/header even when its main content hasn't streamed in yet.

* fix(a11y,metadata-link): wait for host content before axe + cache resolver config permanently

Previous push reduced failures from 5 to 3 tests; remaining 3 all fail with 'No elements found for include in page Context': /full (despite 30s wait for .item-page + ds-item-page-title-field that PASSED), item-edit Bitstreams tab, community-edit Assign Roles tab.

1) testA11y(): when include is a CSS string, wait up to 30s for any child to exist on the host before running axe. Eliminates host-without-content races uniformly across every axe-checked spec.

2) MetadataLinkService: shareReplay refCount true -> false, plus eager subscribe in constructor. Service is providedIn root with combineLatest of 5 backend configuration HTTP calls. On /full item page, async pipes inside @for over metadata rows churn subscribers; with refCount true each churn tears down the inner subscription and re-fetches all 5 properties, causing the template to repeatedly re-evaluate and produce empty intermediate render states (visible as blank main content in the CI failure screenshot). Caching for the service lifetime stabilises the render.

* fix(a11y): pass resolved Element to axe instead of selector string to avoid 'No elements found' race

After previous push, CI improved 3->3 failures but the remaining 3 (community Delete, item-edit Curate, /full) all still fail with 'No elements found for include in page Context'.

Root cause: cypress-axe forwards the string selector context to axe.run, which re-resolves it via document.querySelectorAll at axe.run time. Between Cypress commands (injectAxe reads the axe-core source file, configureAxe evals window.axe.configure) several ms elapse; Angular can re-render and remove the host element from the document for one microtask, making the selector resolve to zero elements.

Fix: in testA11y, after waiting for the host with rendered descendants, resolve the selector ourselves and pass the live DOM Element reference (not the selector string) to cy.checkA11y. axe-core uses the Element directly and skips selector resolution, eliminating the race.

* test(a11y): pass all matched elements to checkA11y, not just first

Addresses Copilot review on PR #1294: when selector matches multiple elements, scanning only \[0] reduced coverage. Use \.toArray() so axe sees all matches like the original string-context did.

Author: milanmajchrak

cypress/e2e/collection-edit.cy.ts

@@ -122,6 +122,9 @@ describe('Edit Collection > Delete page', () => {
     // <ds-delete-collection> tag must be loaded
     cy.get('ds-delete-collection').should('be.visible');
 
+    // Wait for inner content to render before running axe
+    cy.get('ds-delete-collection h1#header', { timeout: 30000 }).should('be.visible');
+
     // Analyze for accessibility issues
     testA11y('ds-delete-collection');
   });

cypress/e2e/community-edit.cy.ts

@@ -80,6 +80,9 @@ describe('Edit Community > Delete page', () => {
     // <ds-delete-community> tag must be loaded
     cy.get('ds-delete-community').should('be.visible');
 
+    // Wait for inner content to render before running axe
+    cy.get('ds-delete-community h1#header', { timeout: 30000 }).should('be.visible');
+
     // Analyze for accessibility issues
     testA11y('ds-delete-community');
   });

cypress/e2e/item-edit.cy.ts

@@ -46,6 +46,9 @@ describe('Edit Item > Status tab', () => {
     // <ds-item-status> tag must be loaded
     cy.get('ds-item-status').should('be.visible');
 
+    // Wait for the actual status content to render before running axe
+    cy.get('ds-item-status .status-label', { timeout: 30000 }).should('be.visible');
+
     // Analyze for accessibility issues
     testA11y('ds-item-status');
   });

cypress/e2e/item-page.cy.ts

@@ -26,6 +26,12 @@ describe('Item  Page', () => {
     // <ds-full-item-page> tag must be loaded
     cy.get('ds-full-item-page').should('be.visible');
 
+    // Wait for the inner content (item-page) to actually render — the host
+    // element gets its size from padding/header even before the item details
+    // resolve, so visibility alone isn't enough for axe to find any nodes.
+    cy.get('ds-full-item-page .item-page', { timeout: 30000 }).should('exist');
+    cy.get('ds-full-item-page ds-item-page-title-field', { timeout: 30000 }).should('be.visible');
+
     // Analyze <ds-full-item-page> for accessibility issues
     testA11y('ds-full-item-page');
   });

cypress/support/utils.ts

@@ -40,5 +40,29 @@ export const testA11y = (context?: any, options?: Options) => {
       { id: 'color-contrast', enabled: false },
     ],
   });
+  // When the include context is a CSS selector string, axe-core re-resolves
+  // that selector at axe.run time via document.querySelectorAll. Between
+  // Cypress commands (injectAxe + configureAxe take a few ms each) Angular
+  // may re-render and the host element can briefly disappear from the
+  // document, causing axe to throw
+  // "No elements found for include in page Context".
+  //
+  // Fix: wait for the host to exist with rendered content, then resolve the
+  // selector to a live DOM Element here and pass that Element reference (not
+  // the selector string) to cy.checkA11y. axe-core uses the Element directly
+  // and does not re-query the document by selector, eliminating the race.
+  if (typeof context === 'string') {
+    cy.get(context, { timeout: 30000 }).should('exist');
+    cy.get(`${context} *`, { timeout: 30000 }).should('exist');
+    cy.get(context).then(($el) => {
+      // Pass ALL matched elements (not just the first) so that selectors which
+      // resolve to multiple nodes preserve the original string-context coverage.
+      // axe-core accepts an Array of Elements as Context.
+      const elements = $el.toArray();
+      // eslint-disable-next-line @typescript-eslint/no-explicit-any
+      cy.checkA11y(elements as any, options, terminalLog);
+    });
+    return;
+  }
   cy.checkA11y(context, options, terminalLog);
 };

src/app/entity-groups/journal-entities/item-list-elements/search-result-list-elements/journal-issue/journal-issue-search-result-list-element.component.html

@@ -4,7 +4,8 @@
       @if (linkType !== linkTypes.None) {
         <a [target]="(linkType === linkTypes.ExternalLink) ? '_blank' : '_self'"
           [attr.rel]="(linkType === linkTypes.ExternalLink) ? 'noopener noreferrer' : null"
-          [routerLink]="[itemPageRoute]" class="lead item-list-title dont-break-out" tabindex="-1">
+          [routerLink]="[itemPageRoute]" class="lead item-list-title dont-break-out" tabindex="-1"
+          [attr.aria-label]="dsoNameService.getName(dso)">
           <ds-thumbnail [thumbnail]="dso?.thumbnail | async" [limitWidth]="true">
           </ds-thumbnail>
         </a>

src/app/entity-groups/journal-entities/item-list-elements/search-result-list-elements/journal-volume/journal-volume-search-result-list-element.component.html

@@ -4,7 +4,8 @@
       @if (linkType !== linkTypes.None) {
         <a [target]="(linkType === linkTypes.ExternalLink) ? '_blank' : '_self'"
           [attr.rel]="(linkType === linkTypes.ExternalLink) ? 'noopener noreferrer' : null"
-          [routerLink]="[itemPageRoute]" class="lead item-list-title dont-break-out" tabindex="-1">
+          [routerLink]="[itemPageRoute]" class="lead item-list-title dont-break-out" tabindex="-1"
+          [attr.aria-label]="dsoNameService.getName(dso)">
           <ds-thumbnail [thumbnail]="dso?.thumbnail | async" [limitWidth]="true">
           </ds-thumbnail>
         </a>

src/app/entity-groups/journal-entities/item-list-elements/search-result-list-elements/journal/journal-search-result-list-element.component.html

@@ -3,7 +3,8 @@
     <div class="col-3 col-md-2">
       @if (linkType !== linkTypes.None) {
         <a [target]="(linkType === linkTypes.ExternalLink) ? '_blank' : '_self'" [attr.rel]="(linkType === linkTypes.ExternalLink) ? 'noopener noreferrer' : null"
-          [routerLink]="[itemPageRoute]" class="lead item-list-title dont-break-out" tabindex="-1">
+          [routerLink]="[itemPageRoute]" class="lead item-list-title dont-break-out" tabindex="-1"
+          [attr.aria-label]="dsoNameService.getName(dso)">
           <ds-thumbnail [thumbnail]="dso?.thumbnail | async" [limitWidth]="true">
           </ds-thumbnail>
         </a>

src/app/entity-groups/research-entities/item-list-elements/search-result-list-elements/project/project-search-result-list-element.component.html

@@ -4,7 +4,8 @@
       @if (linkType !== linkTypes.None) {
         <a [target]="(linkType === linkTypes.ExternalLink) ? '_blank' : '_self'"
           [attr.rel]="(linkType === linkTypes.ExternalLink) ? 'noopener noreferrer' : null"
-          [routerLink]="[itemPageRoute]" class="dont-break-out" tabindex="-1">
+          [routerLink]="[itemPageRoute]" class="dont-break-out" tabindex="-1"
+          [attr.aria-label]="dsoNameService.getName(dso)">
           <ds-thumbnail [thumbnail]="dso?.thumbnail | async"
             [defaultImage]="'assets/images/project-placeholder.svg'"
             [alt]="'thumbnail.project.alt'"

src/app/item-page/edit-item-page/edit-item-page.component.html

@@ -21,7 +21,11 @@ <h1 class="border-bottom">{{'item.edit.head' | translate}}</h1>
                 <span [ngbTooltip]="'item.edit.tabs.disabled.tooltip' | translate">
                   @if ((page.enabled | async) !== true) {
                     <button
-                      class="nav-link disabled">
+                      class="nav-link disabled"
+                      role="tab"
+                      aria-disabled="true"
+                      [attr.aria-selected]="false"
+                      tabindex="-1">
                       {{'item.edit.tabs.' + page.page + '.head' | translate}}
                     </button>
                   }