Commit d0cc2bc
JCU/fix(ssr): serve a reloaded comcol search tab from the page it belongs to
Opening a community or collection moves the address bar to its /search tab, and #1424 put that
path in ssr.excludePathPatterns. Reloading there returned the 1113-byte CSR shell, so the visitor
got a white page for 0.6s on a fast desktop and up to 3.4s on a slow one.
Both URLs render ComcolSearchSectionComponent and the comcol page itself is server-rendered, so a
GET for the bare tab URL is redirected to it; the client puts /search back in the address bar as
it did before. A URL carrying a query is left alone, which is the point of the exclusion: what
saturated SSR on mendelu (#1402) is the Discovery facet parameter space, and those URLs all carry
f. parameters. The redirect turns itself off if the tab stops being excluded, or if the comcol
page ever becomes excluded.
Doing this in ComcolPageBrowseByComponent instead, by not redirecting to the default tab, looks
tidier and does not work: getSearchLink() returns currentPath(router) for an in-place search, so
every facet link would move to /collections/<uuid>?f. , which no pattern matches, and the trap
reopens.
Also fixes the robots.txt comment claiming the SSR-side rule is not configured, wrong since #1424.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>1 parent 28388bb commit d0cc2bc
2 files changed
Lines changed: 34 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
221 | 221 | | |
222 | 222 | | |
223 | 223 | | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
224 | 252 | | |
225 | 253 | | |
226 | 254 | | |
227 | 255 | | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
228 | 261 | | |
229 | 262 | | |
230 | 263 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
34 | | - | |
| 34 | + | |
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
| |||
0 commit comments