Commit eb0b59c
TUL/Fix SSR overlay never revealing: add id="main-content" on <main> (#1358)
The SSR anti-flicker overlay (src/index.html) is removed event-driven only
once AppComponent.dsAppHasRenderedContent() finds dsApp.querySelector(
'#main-content') (src/app/app.component.ts:197). TUL's root template rendered
<main class="main-content"> WITHOUT that id (it predates the upstream
skip-to-main-content commit that other branches carry, so backport #1310
shipped a selector precondition this template never satisfied). The
event-driven reveal could therefore never fire, and the overlay was removed
only by the 10s settle cap (ssrOverlaySettleMaxMs) on EVERY hard reload:
during that window the opaque snapshot masks the live app while clicks pass
through (pointer-events:none) and navigate invisibly -> the page looks frozen
and "does not respond after reload".
Fix: add id="main-content" to <main>, matching zcu-pub/vsb-tuo and the
selector AppComponent already expects. The custom theme reuses this base
template (themes/custom/app/root/root.component.ts), so one edit covers all
themes; app.component.ts is left byte-identical to the other customer
branches (no local selector hardening) to keep backports clean.
Adds a root.component.spec regression test that renders the real template and
asserts #main-content exists — app.component.spec fabricated its own <ds-app>
with the id, which masked this divergence from the unit suite.
Co-authored-by: milanmajchrak <minptai7@gmail.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>1 parent c474d52 commit eb0b59c
2 files changed
Lines changed: 10 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
| 8 | + | |
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
74 | 74 | | |
75 | 75 | | |
76 | 76 | | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
77 | 86 | | |
0 commit comments