Refactoring

Author: jr-rk

src/app/item-page/simple/field-components/clarin-item-versions-field/clarin-item-versions-field.component.html

@@ -2,7 +2,12 @@
   <div class="col-lg-3 col-2-5 d-flex align-self-start">
     <div><i [class]="'fas ' + iconName + ' fa-xs'"></i></div>
     <!-- Toggle Header -->
-    <div class="pl-1 d-flex align-items-center cursor-pointer" (click)="toggleVersionHistory()">
+    <div
+      class="pl-1 d-flex align-items-center"
+      (click)="toggleVersionHistory()"
+      role="button"
+      tabindex="0"
+      [attr.aria-expanded]="showVersionHistory">
       <b class="mr-1">{{ "item.version.history.head" | translate }}</b>
       <i class="fas" [ngClass]="showVersionHistory ? 'fa-chevron-up' : 'fa-chevron-down'"></i>
     </div>

src/app/item-page/simple/field-components/clarin-item-versions-field/clarin-item-versions-field.component.scss

@@ -12,6 +12,6 @@
   border-radius: 4px;
   padding: 2%;
 
-  max-height: 200px;
-  overflow-y: scroll;
+  max-height: var(--ds-dso-selector-list-max-height) / 2;
+  overflow-y: auto;
 }

src/app/item-page/simple/field-components/clarin-item-versions-field/clarin-item-versions-field.component.ts

@@ -157,7 +157,7 @@ export class ClarinItemVersionsFieldComponent implements OnDestroy, OnInit {
    * Get the ID of the workspace item, if present, otherwise return undefined
    * @param versionItem the item for which retrieve the workspace item id
    */
-  getWorkspaceId(versionItem): Observable<string> {
+  getWorkspaceId(versionItem: Observable<RemoteData<Item>>): Observable<string> {
     return versionItem.pipe(
       getFirstSucceededRemoteDataPayload(),
       map((item: Item) => item.uuid),
@@ -171,7 +171,7 @@ export class ClarinItemVersionsFieldComponent implements OnDestroy, OnInit {
    * Get the ID of the workflow item, if present, otherwise return undefined
    * @param versionItem the item for which retrieve the workspace item id
    */
-  getWorkflowId(versionItem): Observable<string> {
+  getWorkflowId(versionItem: Observable<RemoteData<Item>>): Observable<string> {
     return versionItem.pipe(
       getFirstSucceededRemoteDataPayload(),
       map((item: Item) => item.uuid),

src/app/item-page/versions/item-versions.component.scss

@@ -1,17 +0,0 @@
-@import '../simple/item-page.component.scss';
-
-@media (min-width: 992px) {
-  .col-2-5 {
-    flex: 0 0 20%;
-    max-width: 20%;
-  }
-}
-
-.dropdown-versions {
-  background-color: #f8f9fa;
-  border-radius: 4px;
-  padding: 2%;
-
-  max-height: 200px;
-  overflow-y: scroll;
-}