Skip to content

UFAL/Edit bitstreams table UI fix #1131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
milanmajchrak merged 6 commits into from
Jan 12, 2026
Merged

UFAL/Edit bitstreams table UI fix #1131

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c735265
VSB-TUO/Edit bitstreams table - Removed last column (table cells) (#992)
jr-rk Sep 18, 2025
f5ffd05
display of sync status
jr-rk Dec 16, 2025
ad87426
fix: removed wrong i18n translation message and use the correct one; …
jr-rk Dec 17, 2025
1534934
fix: fixed alignment of cells; overflowing the text in Name column
jr-rk Dec 18, 2025
ff3f831
fix: removed unwanted bootstrap class
jr-rk Dec 18, 2025
73ae04c
fix: added word-break css property solution
jr-rk Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/app/item-page/edit-item-page/item-bitstreams/item-bitstreams.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,13 +366,13 @@ export class ItemBitstreamsService {
getColumnSizes(): ResponsiveTableSizes {
return new ResponsiveTableSizes([
// Name column
new ResponsiveColumnSizes(2, 2, 3, 4, 4),
new ResponsiveColumnSizes(3, 3, 3, 3, 3),
// Description column
new ResponsiveColumnSizes(2, 3, 3, 3, 3),
new ResponsiveColumnSizes(3, 3, 3, 3, 3),
// Format column
new ResponsiveColumnSizes(2, 2, 2, 2, 2),
// Actions column
new ResponsiveColumnSizes(6, 5, 4, 3, 3),
new ResponsiveColumnSizes(2, 2, 2, 2, 2),
// Store synchronization columns
new ResponsiveColumnSizes(2, 2, 2, 2, 2)
]);
Expand Down
35 changes: 21 additions & 14 deletions ...page/item-bitstreams/item-edit-bitstream-bundle/item-edit-bitstream-bundle.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,9 @@
<th id="actions" scope="col" class="{{ columnSizes.columns[3].buildClasses() }} text-center">
{{'item.edit.bitstreams.headers.actions' | translate}}
</th>
<th id="synchronized" scope="col" class="{{ columnSizes.columns[4].buildClasses() }} text-center">
{{'item.edit.bitstreams.headers.synchronized' | translate}}
</th>
</tr>
</thead>

Expand All @@ -35,7 +38,7 @@
<th id="{{ bundleName }}" class="span" colspan="3" scope="colgroup">
{{'item.edit.bitstreams.bundle.name' | translate:{ name: bundleName } }}
</th>
<td class="text-center">
<td class="{{ columnSizes.columns[3].buildClasses() }} text-center">

<div class="btn-group">
<button [routerLink]="[itemPageRoute, 'bitstreams', 'new']"
Expand Down Expand Up @@ -74,6 +77,7 @@
</div>

</td>
<td class="{{ columnSizes.columns[4].buildClasses() }}"></td>
</tr>

<ng-container *ngFor="let entry of (tableEntries$ | async)">
Expand All @@ -82,12 +86,14 @@

<th class="bitstream-name row-element {{ columnSizes.columns[0].buildClasses() }}"
scope="row" id="{{ entry.nameStripped }}" headers="{{ bundleName }} name">
<div class="drag-handle text-muted float-left p-1 mr-2" tabindex="0" cdkDragHandle
(keydown.enter)="select($event, entry)" (keydown.space)="select($event, entry)" (click)="select($event, entry)">
<i class="fas fa-grip-vertical fa-fw"
[title]="'item.edit.bitstreams.edit.buttons.drag' | translate"></i>
<div class="d-flex align-items-center">
<div class="drag-handle text-muted p-1 mr-2" tabindex="0" cdkDragHandle
(keydown.enter)="select($event, entry)" (keydown.space)="select($event, entry)" (click)="select($event, entry)">
<i class="fas fa-grip-vertical fa-fw"
[title]="'item.edit.bitstreams.edit.buttons.drag' | translate"></i>
</div>
<span class="flex-grow-1 text-truncate bitstream-name-text" [title]="entry.name">{{ entry.name }}</span>
</div>
{{ entry.name }}
</th>
<td class="row-element {{ columnSizes.columns[1].buildClasses() }}"
headers="{{ entry.nameStripped }} {{ bundleName }} description">
Expand Down Expand Up @@ -128,13 +134,14 @@
</div>
</div>
</td>
<td class="{{columnSizes.columns[4].buildClasses()}} row-element d-flex align-items-center justify-content-center">
<div class="float-left d-flex align-items-center overflow-hidden">
<span class="text-center">
<i [class]="isBitstreamSynchronized(entry) ? 'fas fa-check' : 'fas fa-times'"></i>
</span>
<span class="pl-1">|</span>
<div class="pl-1" [ngTemplateOutlet]="checksum"></div>
<td class="{{columnSizes.columns[4].buildClasses()}} row-element"
headers="{{ entry.nameStripped }} {{ bundleName }} synchronized">
<div class="d-flex align-items-center justify-content-center">
<span class="text-center">
<i [class]="isBitstreamSynchronized(entry) ? 'fas fa-check' : 'fas fa-times'"></i>
</span>
<span class="pl-1">|</span>
<div class="pl-1" [ngTemplateOutlet]="checksum"></div>
</div>
</td>
</tr>
Expand All @@ -149,7 +156,7 @@
</ng-template>

<ng-template #checksum let-entry="entry">
<div class="hover-container"
<div class="d-flex align-items-center"
(mouseenter)="showChecksumValues = true"
(mouseleave)="showChecksumValues = false"
*ngVar="(checkSum$ | async) as bitstreamChecksum">
Expand Down
9 changes: 9 additions & 0 deletions ...page/item-bitstreams/item-edit-bitstream-bundle/item-edit-bitstream-bundle.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,15 @@
font-weight: normal;
}

.bitstream-name-text {
width: 0;
Comment thread
jr-rk marked this conversation as resolved.
Outdated
overflow: auto;
}

.table {
margin-bottom: 0;
}

.table thead th {
vertical-align: middle;
}
Loading