CLARIN-DSpace v9/Port #1415 (fix the causes of the REST self link console warnings) to the v9 base

[milanmajchrak]

What

Port of dtq-dev PR #1415 (d0897c2af7) to the v9 base — card FE-06 (tranche T1) of the
dtq-dev → dtq-dev-9-base sync.

Removes the bogus self link doesn't match console warnings, and stops asking the REST API for
page sizes it does not honour.

Why

ensureSelfLink() stripped embed params from the requested url only, so any request embedding a
subresource compared a url the frontend had normalised against a self link the API had not — and
reported a mismatch it had created itself. The API additionally percent-decodes : and /, which
are legal in a query component, which looked like a further difference.

The second cause is the call sites asking for 9999 / 10000 / 1000 elements to mean
"everything". Spring Data REST caps a page at spring.data.rest.max-page-size (DSpace leaves the
default 1000), so those requests never returned more than 1000 rows — they only made the request
claim something the API does not honour, leaving the self link legitimately different from the
requested url.

Changes

• both sides are normalised before comparison (urlPartsDiffer, decodeUrlParts,
  isUnexpectedSelfLink); a difference in an actual value still warns
• MAX_PAGE_SIZE next to FindListOptions, used by every "give me everything" call site
  (15 files; 9999|10000|1000 literals in src/app go 15 → 0)
• the condition that rewrites _links.self is untouched — the url a response is cached under is
  unchanged; only whether we warn changes
• first spec this service has had: 17 cases, covering both what is now tolerated and what must
  still warn

v9 adaptations

The text is the 9.3-native original (customer/jcu ca40c3b9c2, jcu PR #1440) — the same change
already formatted for the v9 eslint import rules. registry.service.ts was resolved by hand to keep
the CLARIN MetadataBitstreamDataService import. The six CLARIN-only call sites were hand-applied
from d0897c2af7; the #1400 (ROR) and #1396 (route-aware submission PATCH) hunks in
clarin-item-box-view.component.ts and section-license.component.ts are untouched.

Two call sites exist only on v9 and therefore only in the jcu commit — filtered-items.component.ts
(4 × 10000; the file does not exist on dtq-dev) and relationship-type-data.service.ts (dtq-dev
still pages it with elementsPerPage: 20). browse-by-geospatial-data.component.ts is deliberately
left alone: its 99999 is a Discovery facet limit, not a Spring Data REST page size.

Testing

Local gates (Windows, Node 20.19.0):

npm run lint:nobuild -- --quiet      All files pass linting.                EXIT=0
npx madge (check-circ-deps)          No circular dependency found!          EXIT=0
npm run build:prod                   EXIT=0, dist/{browser,server}
karma (target spec)                  TOTAL: 17 SUCCESS
karma (7 neighbour specs)            TOTAL: 93 SUCCESS

Acceptance greps: MAX_PAGE_SIZE = 1000 → 1; urlPartsDiffer|decodeUrlParts → 2; files using
MAX_PAGE_SIZE → 15; magic 9999|10000|1000 literals in src/app → 0 (was 15); _links.self
rewrite unchanged vs dspace-9.3 → 0 diff.

Sync guards: X1 none of the 15 touched files is byte-identical with dspace-9.3 on the head
(six of them were, on the base — this port is what takes them off that list). X6 clarin*.spec.ts
count unchanged at 5, no removed cy./expect( in cypress/. X5b orphan/fork-only i18n counts
identical to the base (no json5 touched).

Two environmental caveats, both proven pre-existing by re-running on the untouched base:
npm run test:lint:nobuild is 8/169 red (Windows backslash paths in lint/test/fixture, nothing
under lint/ is touched — CI on Linux is the gate), and check-circ-deps cannot run through
cmd.exe, so the identical npx madge invocation was run from Git Bash.

[live] acceptance criteria are verified after merge and deploy on dev-6:8603, per the sync
acceptance document.

Notes for the reviewer

• Follow-up [Port to dtq-dev] fix(self-link): say what happened when the REST API reduces a page size #1490 (card FE-01) is branched on top of this one and will be rebased and opened
  once this merges.
• Source: d0897c2af7 (dtq-dev PR Fix the causes of the REST self link console warnings #1415) · adapted from ca40c3b9c2 (customer/jcu PR Fix the causes of the REST self link console warnings #1440).

🤖 Generated with Claude Code