Skip to content

VSB-TUO/Implemented original VSB-TUO fonts - #963

Merged
milanmajchrak merged 1 commit into
customer/vsb-tuofrom
vsb-tuo/add-original-vsb-fonts
Sep 2, 2025
Merged

VSB-TUO/Implemented original VSB-TUO fonts#963
milanmajchrak merged 1 commit into
customer/vsb-tuofrom
vsb-tuo/add-original-vsb-fonts

Conversation

@jr-rk

@jr-rk jr-rk commented Sep 2, 2025

Copy link
Copy Markdown
Phases MP MM MB MR JM Total
ETA 0 0 0 0 0 0
Developing 0 0 0 0 0 0
Review 0 0 0 0 0 0
Total - - - - - 0
ETA est. 0
ETA cust. - - - - - 0

Problem description

Original (licensed) fonts were missing.

@jr-rk jr-rk self-assigned this Sep 2, 2025
@jr-rk jr-rk linked an issue Sep 2, 2025 that may be closed by this pull request
@coderabbitai

coderabbitai Bot commented Sep 2, 2025

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch vsb-tuo/add-original-vsb-fonts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements the original VSB-TUO licensed fonts by adding a new DriveProp font family and expanding the existing Drive font family with additional weights and styles. The changes replace OTF format fonts with modern WOFF/WOFF2 formats and add comprehensive font weight variations.

  • Added new DriveProp font family with regular, medium, and bold weights in both normal and italic styles
  • Expanded Drive font family from 5 to 12 font-face declarations covering weights from thin (100) to extrabold (800)
  • Updated font formats from OTF to WOFF2/WOFF for better web performance and broader browser support

Reviewed Changes

Copilot reviewed 3 out of 57 changed files in this pull request and generated no comments.

File Description
src/themes/custom/styles/_theme_sass_variable_overrides.scss Imports the new DriveProp font stylesheet
src/themes/custom/assets/fonts/driveProp.scss Defines font-face declarations for the new DriveProp font family
src/themes/custom/assets/fonts/drive.scss Updates existing Drive font with expanded weights and modern WOFF formats
Comments suppressed due to low confidence (1)

src/themes/custom/assets/fonts/drive.scss:1

  • Both 'Drive-Hairline' and 'Drive-Extralight' are assigned the same font-weight of 200. This creates ambiguity as browsers won't be able to distinguish between these variants when the same weight is requested. Consider assigning different weights (e.g., 100 for hairline, 200 for extralight) or removing one of the duplicate weight declarations.
@font-face {

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@milanmajchrak
milanmajchrak merged commit 49b266c into customer/vsb-tuo Sep 2, 2025
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants