VSB-TUO/Implemented original VSB-TUO fonts - #963
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Pull Request Overview
This PR implements the original VSB-TUO licensed fonts by adding a new DriveProp font family and expanding the existing Drive font family with additional weights and styles. The changes replace OTF format fonts with modern WOFF/WOFF2 formats and add comprehensive font weight variations.
- Added new DriveProp font family with regular, medium, and bold weights in both normal and italic styles
- Expanded Drive font family from 5 to 12 font-face declarations covering weights from thin (100) to extrabold (800)
- Updated font formats from OTF to WOFF2/WOFF for better web performance and broader browser support
Reviewed Changes
Copilot reviewed 3 out of 57 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/themes/custom/styles/_theme_sass_variable_overrides.scss | Imports the new DriveProp font stylesheet |
| src/themes/custom/assets/fonts/driveProp.scss | Defines font-face declarations for the new DriveProp font family |
| src/themes/custom/assets/fonts/drive.scss | Updates existing Drive font with expanded weights and modern WOFF formats |
Comments suppressed due to low confidence (1)
src/themes/custom/assets/fonts/drive.scss:1
- Both 'Drive-Hairline' and 'Drive-Extralight' are assigned the same font-weight of 200. This creates ambiguity as browsers won't be able to distinguish between these variants when the same weight is requested. Consider assigning different weights (e.g., 100 for hairline, 200 for extralight) or removing one of the duplicate weight declarations.
@font-face {
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Problem description
Original (licensed) fonts were missing.