Skip to content

VSB-TUO/Admin sidebar submenu buttons clickable as block - #967

Merged
milanmajchrak merged 4 commits into
customer/vsb-tuofrom
vsb-tuo/make-whole-buttons-clickable
Sep 16, 2025
Merged

VSB-TUO/Admin sidebar submenu buttons clickable as block#967
milanmajchrak merged 4 commits into
customer/vsb-tuofrom
vsb-tuo/make-whole-buttons-clickable

Conversation

@jr-rk

@jr-rk jr-rk commented Sep 8, 2025

Copy link
Copy Markdown
Phases MP MM MB MR JM Total
ETA 0 0 0 0 0 0
Developing 0 0 0 0 0 0
Review 0 0 0 0 0 0
Total - - - - - 0
ETA est. 0
ETA cust. - - - - - 0

Problem description

In the expandable admin sidebar section submenu items was only text clickable link.

@jr-rk
jr-rk requested a review from Copilot September 8, 2025 14:04
@jr-rk jr-rk self-assigned this Sep 8, 2025
@coderabbitai

coderabbitai Bot commented Sep 8, 2025

Copy link
Copy Markdown

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch vsb-tuo/make-whole-buttons-clickable

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

This comment was marked as outdated.

@jr-rk
jr-rk requested a review from milanmajchrak September 8, 2025 14:12
@jr-rk
jr-rk requested a review from Copilot September 9, 2025 08:26

This comment was marked as outdated.

@jr-rk
jr-rk requested a review from Copilot September 9, 2025 10:18

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the UX of the admin sidebar by making submenu items fully clickable as blocks instead of just the anchor text being clickable.

  • Converts anchor elements in submenu items to full-width clickable blocks
  • Applies proper padding to anchors to make the entire row area clickable
  • Adjusts vertical padding to prevent double padding on nested elements

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
expandable-admin-sidebar-section.component.scss Converts submenu anchors to full-width blocks and applies padding for clickable area
admin-sidebar.component.scss Resets padding on nested sidebar items to prevent double padding

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread src/app/admin/admin-sidebar/admin-sidebar.component.scss Outdated
@milanmajchrak
milanmajchrak merged commit 0d58dd1 into customer/vsb-tuo Sep 16, 2025
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants