Skip to content

VSB-TUO/Admin sidebar submenu buttons clickable as block #967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
milanmajchrak merged 4 commits into from
Sep 16, 2025
Merged

VSB-TUO/Admin sidebar submenu buttons clickable as block #967

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a80fc16
Making admin sidebar submenu items clickable as block
jr-rk Sep 8, 2025
a59a9d6
Added style for expandable-admin-sidebar-section to sidebar-sub-level…
jr-rk Sep 9, 2025
4ae5af6
Copilot suggestion refactoring - removed the !important keywords
jr-rk Sep 9, 2025
11c4e24
removed whitespace
jr-rk Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/app/admin/admin-sidebar/admin-sidebar.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,15 @@
padding-bottom: var(--ds-admin-sidebar-item-padding);
}

// Remove vertical padding from the wrapper and apply it to the anchor
// In case an anchor also has .sidebar-item, reset it to avoid double padding
.sidebar-sub-level-item-list {
.sidebar-item, .ds-menu-item.sidebar-item {
padding-top: 0;
padding-bottom: 0;
}
}

// These classes handle the collapsing behavior
.sidebar-section-wrapper {

Expand Down
15 changes: 13 additions & 2 deletions ...-sidebar/expandable-admin-sidebar-section/expandable-admin-sidebar-section.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,19 @@
list-style: none;
margin: 0;
padding: 0;
::ng-deep .ds-menu-item {
margin-left: var(--ds-admin-sidebar-section-indent);
/* Make the entire sub-level row clickable by applying padding to the anchor */
::ng-deep {
/* Ensure anchors are full-width blocks */
.ds-menu-item {
display: block;
width: 100%;
padding-left: var(--ds-admin-sidebar-section-indent);
}

.sidebar-item .ds-menu-item {
padding-top: var(--ds-admin-sidebar-item-padding);
padding-bottom: var(--ds-admin-sidebar-item-padding);
}
}
}

Expand Down
2 changes: 1 addition & 1 deletion src/app/shared/menu/menu-item/onclick-menu-item.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
a {
cursor: pointer;
}
}
Loading