Skip to content

Commit 8d1e7ec

Browse files
author
jm
committed
ci: report the typecheck job green (step-level continue-on-error)
Job-level continue-on-error still surfaces the job as a failed check on the PR; moving it to the mypy step lets the job pass green while mypy stays advisory.
1 parent 7e562c0 commit 8d1e7ec

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

.github/workflows/tests.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,13 +56,14 @@ jobs:
5656
5757
typecheck:
5858
runs-on: ubuntu-latest
59-
# Non-blocking: strict typing is being introduced incrementally.
60-
continue-on-error: true
6159
steps:
6260
- uses: actions/checkout@v6
6361

6462
- name: Install uv
6563
uses: astral-sh/setup-uv@v6
6664

6765
- name: Mypy
66+
# Non-blocking: strict typing is being introduced incrementally, so a
67+
# mypy failure is reported but does not fail the (green) job.
68+
continue-on-error: true
6869
run: uvx --with requests --with pysolr mypy dspace_rest_client

0 commit comments

Comments
 (0)