fix: address Copilot review (handler guard, header copy, docstrings)

- guard the NullHandler registration so reloads/re-imports don't accumulate
  duplicate handlers
- create_bitstream: copy the session headers before adding Content-Encoding so
  it doesn't leak onto every subsequent request / across threads
- move Collection.as_dict's docstring to the first statement (it was a no-op
  string literal after code); rename the `dict` builtin-shadow in
  InProgressSubmission.as_dict

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Author: jm

dspace_rest_client/client.py

@@ -28,9 +28,11 @@
 
 _logger = logging.getLogger("dspace.client")
 # A library must not configure the root logger - that is the consuming
-# application's job. Attach a NullHandler so records are dropped unless the
-# application opts in to logging.
-_logger.addHandler(logging.NullHandler())
+# application's job. Attach a NullHandler (once) so records are dropped unless
+# the application opts in to logging - guarded so reloads/re-imports don't
+# accumulate duplicate handlers.
+if not any(isinstance(h, logging.NullHandler) for h in _logger.handlers):
+    _logger.addHandler(logging.NullHandler())
 
 
 def parse_json(response):
@@ -857,7 +859,9 @@ def create_bitstream(self, bundle=None, name=None, path=None, mime=None, metadat
             files = {'file': (name, fh, mime)}
             properties = {'name': name, 'metadata': metadata, 'bundleName': bundle.name}
             payload = {'properties': json.dumps(properties) + ';application/json'}
-            h = self.session.headers
+            # copy the session headers so this request's Content-Encoding does
+            # not leak onto every subsequent request (and across threads)
+            h = dict(self.session.headers)
             h.update({'Content-Encoding': 'gzip', 'User-Agent': self.USER_AGENT})
             req = Request('POST', url, data=payload, headers=h, files=files)
             prepared_req = self.session.prepare_request(req)

dspace_rest_client/models.py

@@ -316,11 +316,11 @@ def __init__(self, api_resource=None):
         self.type = 'collection'
 
     def as_dict(self):
-        dso_dict = super().as_dict()
         """
         Return a dict representation of this Collection, based on super with collection-specific attributes added
         @return: dict of Item for API use
         """
+        dso_dict = super().as_dict()
         collection_dict = {}
         return {**dso_dict, **collection_dict}
 
@@ -488,13 +488,13 @@ def __init__(self, api_resource):
 
     def as_dict(self):
         parent_dict = super().as_dict()
-        dict = {
+        submission_dict = {
             'lastModified': self.lastModified,
             'step': self.step,
             'sections': self.sections,
             'type': self.type
         }
-        return {**parent_dict, **dict}
+        return {**parent_dict, **submission_dict}
 
 class WorkspaceItem(InProgressSubmission):