UoE/datashare: add "Keep embargo policies" option to the move-item screen

Companion to backend PR dataquest-dev/uoe-dspace-datashare-backend#27
(dspace-customers#761 - embargo lost when moving into another collection).

When moving an item and inheriting the destination collection's policies, let
the user choose whether to keep an existing embargo:
- checked (default): inherit everything except the embargo (keepEmbargoPolicies=true)
- unchecked: plain DSpace behaviour - inherited default read lifts the embargo

The checkbox is shown only when "Inherit policies" is ticked.

- item-move.component: keepEmbargoPolicies model (default true), passed to
  moveToCollection only when inheriting.
- item-move.component.html: checkbox + description gated on inheritPolicies.
- item-data.service: send &keepEmbargoPolicies= on the owningCollection move.
- en.json5: item.edit.move.keepembargopolicies.{checkbox,description,tooltip}.
- item-move.component.spec: updated expectation + case for inheriting.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Author: milanmajchrak

src/app/core/data/item-data.service.ts

@@ -272,27 +272,36 @@ export abstract class BaseItemDataService extends IdentifiableDataService<Item>
   /**
    * Get the endpoint to move the item
    * @param itemId
+   * @param inheritPolicies whether to inherit the destination collection's default policies
+   * @param keepEmbargoPolicies when inheriting, whether to keep an existing embargo (only the
+   *                            non-embargo access is inherited) instead of letting the inherited
+   *                            default read access lift it
    */
-  public getMoveItemEndpoint(itemId: string, inheritPolicies: boolean): Observable<string> {
+  public getMoveItemEndpoint(itemId: string, inheritPolicies: boolean, keepEmbargoPolicies = true): Observable<string> {
     return this.halService.getEndpoint(this.linkPath).pipe(
       map((endpoint: string) => this.getIDHref(endpoint, itemId)),
-      map((endpoint: string) => `${endpoint}/owningCollection?inheritPolicies=${inheritPolicies}`),
+      map((endpoint: string) =>
+        `${endpoint}/owningCollection?inheritPolicies=${inheritPolicies}&keepEmbargoPolicies=${keepEmbargoPolicies}`),
     );
   }
 
   /**
    * Move the item to a different owning collection
    * @param itemId
    * @param collection
+   * @param inheritPolicies whether to inherit the destination collection's default policies
+   * @param keepEmbargoPolicies when inheriting, whether to keep an existing embargo
    */
-  public moveToCollection(itemId: string, collection: Collection, inheritPolicies: boolean): Observable<RemoteData<any>> {
+  public moveToCollection(
+    itemId: string, collection: Collection, inheritPolicies: boolean, keepEmbargoPolicies = true,
+  ): Observable<RemoteData<any>> {
     const options: HttpOptions = Object.create({});
     let headers = new HttpHeaders();
     headers = headers.append('Content-Type', 'text/uri-list');
     options.headers = headers;
 
     const requestId = this.requestService.generateRequestId();
-    const hrefObs = this.getMoveItemEndpoint(itemId, inheritPolicies);
+    const hrefObs = this.getMoveItemEndpoint(itemId, inheritPolicies, keepEmbargoPolicies);
 
     hrefObs.pipe(
       find((href: string) => hasValue(href)),

src/app/item-page/edit-item-page/item-move/item-move.component.html

@@ -32,6 +32,19 @@ <h1>{{'item.edit.move.head' | translate: {id: (itemRD$ | async)?.payload?.handle
                     <p>
                         {{'item.edit.move.inheritpolicies.description' | translate}}
                     </p>
+                    <p *ngIf="inheritPolicies">
+                      <label for="keepEmbargoPoliciesCheckbox">
+                        <ng-template #keepEmbargoTooltipContent>
+                          {{ 'item.edit.move.keepembargopolicies.tooltip' | translate }}
+                        </ng-template>
+                        <input type="checkbox" name="keepEmbargo" [(ngModel)]="keepEmbargoPolicies" id="keepEmbargoPoliciesCheckbox" [ngbTooltip]="keepEmbargoTooltipContent"
+                        >
+                        {{'item.edit.move.keepembargopolicies.checkbox' | translate}}
+                      </label>
+                    </p>
+                    <p *ngIf="inheritPolicies">
+                        {{'item.edit.move.keepembargopolicies.description' | translate}}
+                    </p>
                 </div>
             </div>
 

src/app/item-page/edit-item-page/item-move/item-move.component.spec.ts

@@ -150,7 +150,20 @@ describe('ItemMoveComponent', () => {
         comp.inheritPolicies = false;
         comp.moveToCollection();
 
-        expect(itemDataService.moveToCollection).toHaveBeenCalledWith('item-id', collection1, false);
+        // keepEmbargoPolicies is only meaningful when inheriting; not inheriting always sends true
+        expect(itemDataService.moveToCollection).toHaveBeenCalledWith('item-id', collection1, false, true);
+      });
+      it('should pass keepEmbargoPolicies through when inheriting policies', () => {
+        comp.item = Object.assign(new Item(), {
+          id: 'item-id',
+          uuid: 'item-id',
+        });
+        comp.selectedCollection = collection1;
+        comp.inheritPolicies = true;
+        comp.keepEmbargoPolicies = false;
+        comp.moveToCollection();
+
+        expect(itemDataService.moveToCollection).toHaveBeenCalledWith('item-id', collection1, true, false);
       });
       it('should call notificationsService success message on success', () => {
         comp.moveToCollection();

src/app/item-page/edit-item-page/item-move/item-move.component.ts

@@ -73,6 +73,13 @@ export class ItemMoveComponent implements OnInit {
   selectorType = DSpaceObjectType.COLLECTION;
 
   inheritPolicies = false;
+
+  /**
+   * When inheriting the destination collection's policies, whether to keep an existing embargo
+   * (only the non-embargo access is inherited) instead of letting the inherited default read
+   * access lift it. Only relevant while {@link inheritPolicies} is enabled.
+   */
+  keepEmbargoPolicies = true;
   itemRD$: Observable<RemoteData<Item>>;
   originalCollection: Collection;
 
@@ -145,8 +152,10 @@ export class ItemMoveComponent implements OnInit {
    */
   moveToCollection() {
     this.processing = true;
-    const move$ = this.itemDataService.moveToCollection(this.item.id, this.selectedCollection, this.inheritPolicies)
-      .pipe(getFirstCompletedRemoteData());
+    const move$ = this.itemDataService.moveToCollection(
+      this.item.id, this.selectedCollection, this.inheritPolicies,
+      this.inheritPolicies ? this.keepEmbargoPolicies : true,
+    ).pipe(getFirstCompletedRemoteData());
 
     move$.subscribe((response: RemoteData<any>) => {
       if (response.hasSucceeded) {

src/assets/i18n/en.json5

@@ -2552,6 +2552,12 @@
 
   "item.edit.move.inheritpolicies.tooltip": "Warning: When enabled, the read access policy for the item and any files associated with the item will be replaced by the default read access policy of the collection. This cannot be undone.",
 
+  "item.edit.move.keepembargopolicies.checkbox": "Keep embargo policies",
+
+  "item.edit.move.keepembargopolicies.description": "When inheriting policies, keep any existing embargo: only the non-embargo access is inherited from the destination collection.",
+
+  "item.edit.move.keepembargopolicies.tooltip": "When enabled, inheriting the destination collection's policies preserves an existing embargo, so embargoed files stay embargoed until their original lift date. When disabled, the inherited default read access replaces (and lifts) the embargo.",
+
   "item.edit.move.move": "Move",
 
   "item.edit.move.processing": "Moving...",