feat(statistics): show scoped top-items report on community and collection statistics pages

Adds the new backend TopItems report to the community and collection statistics pages so each lists (and paginates through) the most-visited items within that scope, mirroring the site-level page. Also clears each statistics table's pagination query params on destroy so a page/rpp selection does not leak (via queryParamsHandling: 'merge') into the next scope's statistics page.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Author: jr-rk

src/app/statistics-page/collection-statistics-page/collection-statistics-page.component.spec.ts

@@ -83,7 +83,7 @@ describe('CollectionStatisticsPageComponent', () => {
         { provide: DSpaceObjectDataService, useValue: {} },
         { provide: DSONameService, useValue: nameService },
         { provide: AuthService, useValue: authService },
-        { provide: PaginationService, useValue: { getCurrentPagination: () => observableOf({ currentPage: 1, pageSize: 10 }) } },
+        { provide: PaginationService, useValue: { getCurrentPagination: () => observableOf({ currentPage: 1, pageSize: 10 }), clearPagination: () => undefined } },
       ],
     })
       .compileComponents();
@@ -110,6 +110,8 @@ describe('CollectionStatisticsPageComponent', () => {
       .toBeTruthy();
     expect(de.query(By.css('ds-statistics-table.collection_id-TotalVisitsPerMonth-report')).nativeElement)
       .toBeTruthy();
+    expect(de.query(By.css('ds-statistics-table.collection_id-TopItems-report')).nativeElement)
+      .toBeTruthy();
     expect(de.query(By.css('ds-statistics-table.collection_id-TopCountries-report')).nativeElement)
       .toBeTruthy();
     expect(de.query(By.css('ds-statistics-table.collection_id-TopCities-report')).nativeElement)

src/app/statistics-page/collection-statistics-page/collection-statistics-page.component.ts

@@ -26,6 +26,7 @@ export class CollectionStatisticsPageComponent extends StatisticsPageDirective<C
   types: string[] = [
     'TotalVisits',
     'TotalVisitsPerMonth',
+    'TopItems',
     'TopCountries',
     'TopCities',
   ];

src/app/statistics-page/community-statistics-page/community-statistics-page.component.spec.ts

@@ -83,7 +83,7 @@ describe('CommunityStatisticsPageComponent', () => {
         { provide: DSpaceObjectDataService, useValue: {} },
         { provide: DSONameService, useValue: nameService },
         { provide: AuthService, useValue: authService },
-        { provide: PaginationService, useValue: { getCurrentPagination: () => observableOf({ currentPage: 1, pageSize: 10 }) } },
+        { provide: PaginationService, useValue: { getCurrentPagination: () => observableOf({ currentPage: 1, pageSize: 10 }), clearPagination: () => undefined } },
       ],
     })
       .compileComponents();
@@ -110,6 +110,8 @@ describe('CommunityStatisticsPageComponent', () => {
       .toBeTruthy();
     expect(de.query(By.css('ds-statistics-table.community_id-TotalVisitsPerMonth-report')).nativeElement)
       .toBeTruthy();
+    expect(de.query(By.css('ds-statistics-table.community_id-TopItems-report')).nativeElement)
+      .toBeTruthy();
     expect(de.query(By.css('ds-statistics-table.community_id-TopCountries-report')).nativeElement)
       .toBeTruthy();
     expect(de.query(By.css('ds-statistics-table.community_id-TopCities-report')).nativeElement)

src/app/statistics-page/community-statistics-page/community-statistics-page.component.ts

@@ -26,6 +26,7 @@ export class CommunityStatisticsPageComponent extends StatisticsPageDirective<Co
   types: string[] = [
     'TotalVisits',
     'TotalVisitsPerMonth',
+    'TopItems',
     'TopCountries',
     'TopCities',
   ];

src/app/statistics-page/item-statistics-page/item-statistics-page.component.spec.ts

@@ -83,7 +83,7 @@ describe('ItemStatisticsPageComponent', () => {
         { provide: DSpaceObjectDataService, useValue: {} },
         { provide: DSONameService, useValue: nameService },
         { provide: AuthService, useValue: authService },
-        { provide: PaginationService, useValue: { getCurrentPagination: () => observableOf({ currentPage: 1, pageSize: 10 }) } },
+        { provide: PaginationService, useValue: { getCurrentPagination: () => observableOf({ currentPage: 1, pageSize: 10 }), clearPagination: () => undefined } },
       ],
     })
       .compileComponents();

src/app/statistics-page/site-statistics-page/site-statistics-page.component.spec.ts

@@ -84,7 +84,7 @@ describe('SiteStatisticsPageComponent', () => {
         { provide: DSONameService, useValue: nameService },
         { provide: SiteDataService, useValue: siteService },
         { provide: AuthService, useValue: authService },
-        { provide: PaginationService, useValue: { getCurrentPagination: () => observableOf({ currentPage: 1, pageSize: 10 }) } },
+        { provide: PaginationService, useValue: { getCurrentPagination: () => observableOf({ currentPage: 1, pageSize: 10 }), clearPagination: () => undefined } },
       ],
     })
       .compileComponents();

src/app/statistics-page/statistics-table/statistics-table.component.spec.ts

@@ -47,6 +47,7 @@ describe('StatisticsTableComponent', () => {
 
   const paginationService = {
     getCurrentPagination: (_id: string, _options: PaginationComponentOptions) => currentPagination$.asObservable(),
+    clearPagination: (_id: string) => undefined,
   };
 
   const setPage = (currentPage: number, pageSize = 10) => {
@@ -221,4 +222,42 @@ describe('StatisticsTableComponent', () => {
       expect(de.query(By.css(`td.item_${numberOfPoints - 1}-views-data`))).toBeTruthy();
     });
   });
+
+  describe('on destroy', () => {
+
+    it('should clear its own pagination params so they do not leak to the next scope', () => {
+      component.report = Object.assign(new UsageReport(), {
+        id: 'uuid_TopItems',
+        points: [],
+      });
+      component.ngOnInit();
+      const spy = spyOn(paginationService, 'clearPagination');
+
+      fixture.destroy();
+
+      expect(spy).toHaveBeenCalledWith('stats-uuid_TopItems');
+    });
+
+    it('should not throw when destroyed before initialisation', () => {
+      const uninitialised = TestBed.createComponent(StatisticsTableComponent).componentInstance;
+      expect(() => uninitialised.ngOnDestroy()).not.toThrow();
+    });
+  });
+
+  describe('getLabel', () => {
+
+    it('should return the point label for a TopItems report without resolving the DSO', (done) => {
+      // DSpaceObjectDataService is provided as {} in this suite, so any findById lookup would throw — proving
+      // the TopItems path relies solely on the label the backend already supplied.
+      component.report = Object.assign(new UsageReport(), {
+        reportType: 'TopItems',
+        points: [],
+      });
+
+      component.getLabel({ id: 'item-uuid', label: 'My item', type: 'item', values: [{ views: 3 }] }).subscribe((label) => {
+        expect(label).toEqual('My item');
+        done();
+      });
+    });
+  });
 });

src/app/statistics-page/statistics-table/statistics-table.component.ts

@@ -6,6 +6,7 @@ import {
 import {
   Component,
   Input,
+  OnDestroy,
   OnInit,
 } from '@angular/core';
 import {
@@ -43,7 +44,7 @@ import { PaginationComponentOptions } from '../../shared/pagination/pagination-c
   standalone: true,
   imports: [NgIf, NgFor, AsyncPipe, TranslateModule, PaginationComponent],
 })
-export class StatisticsTableComponent implements OnInit {
+export class StatisticsTableComponent implements OnInit, OnDestroy {
 
   /**
    * The usage report to display a statistics table for
@@ -110,6 +111,14 @@ export class StatisticsTableComponent implements OnInit {
     );
   }
 
+  ngOnDestroy() {
+    // Drop this table's page/rpp query params so they don't leak (via queryParamsHandling: 'merge') to the next
+    // scope's statistics page. Guarded in case the component is destroyed before ngOnInit ran.
+    if (this.paginationOptions) {
+      this.paginationService.clearPagination(this.paginationOptions.id);
+    }
+  }
+
   /**
    * Get the row label to display for a statistics point.
    * @param point the statistics point to get the label for

src/assets/i18n/en.json5

@@ -4814,6 +4814,8 @@
 
   "statistics.table.title.TopCities": "Top city views",
 
+  "statistics.table.title.TopItems": "Top item views",
+
   "statistics.table.header.views": "Views",
 
   "statistics.table.no-name": "(object name could not be loaded)",