UoE/datashare: address Copilot review - pass keepEmbargoPolicies through directly

getMoveItemEndpoint already omits keepEmbargoPolicies unless inheriting, so the
component no longer needs the 'inheritPolicies ? keepEmbargoPolicies : true'
conditional - it passes keepEmbargoPolicies straight through. Also reword the
spec comment (keepEmbargoPolicies defaults to true and is only sent when
inheriting).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Author: milanmajchrak

src/app/item-page/edit-item-page/item-move/item-move.component.spec.ts

@@ -150,7 +150,7 @@ describe('ItemMoveComponent', () => {
         comp.inheritPolicies = false;
         comp.moveToCollection();
 
-        // keepEmbargoPolicies is only meaningful when inheriting; not inheriting always sends true
+        // keepEmbargoPolicies defaults to true; it is only sent on the request URL when inheriting
         expect(itemDataService.moveToCollection).toHaveBeenCalledWith('item-id', collection1, false, true);
       });
       it('should pass keepEmbargoPolicies through when inheriting policies', () => {

src/app/item-page/edit-item-page/item-move/item-move.component.ts

@@ -152,9 +152,10 @@ export class ItemMoveComponent implements OnInit {
    */
   moveToCollection() {
     this.processing = true;
+    // keepEmbargoPolicies is only sent (and only matters) when inheriting; getMoveItemEndpoint omits
+    // it otherwise, so we can pass it straight through.
     const move$ = this.itemDataService.moveToCollection(
-      this.item.id, this.selectedCollection, this.inheritPolicies,
-      this.inheritPolicies ? this.keepEmbargoPolicies : true,
+      this.item.id, this.selectedCollection, this.inheritPolicies, this.keepEmbargoPolicies,
     ).pipe(getFirstCompletedRemoteData());
 
     move$.subscribe((response: RemoteData<any>) => {