Conversation
…ion and development
…ON)` to be copy-paste
…_FAKE_GEN_STREAM` flag when uploading media from url
# Conflicts: # pywa/cli.py
default_flow_request_decryptor called load_pem_private_key on every flow data exchange. Parsing a PEM is expensive — cryptography validates the RSA key material on load — and it dominated the cost of the decryption it exists to enable: ~56ms against ~2.8ms for the rest of the request, with or without a password on the key. That put a ceiling of roughly 18 exchanges per second per core on any flow endpoint, in synchronous CPU work, to re-answer a question whose answer never changes for the life of the process. The key is now parsed once per (private_key, password) pair through a bounded lru_cache, taking the same request to ~2.8ms — about 20x, and a ceiling nearer 355/s/core. The cache keys come from the developer's own configuration and never from a request.
Cache the flow private key instead of parsing it on every request
…essaging_limit` and add deprecation warning. resolves #221
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #222 +/- ##
===========================================
- Coverage 87.81% 58.86% -28.96%
===========================================
Files 15 29 +14
Lines 3407 2076 -1331
===========================================
- Hits 2992 1222 -1770
- Misses 415 854 +439 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.