Skip to content

Fix: Make grain optional (default None) in GroupByParam #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jairus-m merged 3 commits into from
May 22, 2026
Merged

Fix: Make grain optional (default None) in GroupByParam #104

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1476124
Make grain optional in GroupByParam
jairus-m May 22, 2026
ea3d0a9
Update contextmanager return types from Iterator to Generator for bas…
jairus-m May 22, 2026
4621c34
Use existing customer__customer_type categorical dimension for test
jairus-m May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changes/unreleased/Fixes-20260521-210810.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
kind: Fixes
body: Make grain optional (default None) in GroupByParam so categorical group_by dimensions do not require a grain field
time: 2026-05-21T21:08:10.518263-07:00
2 changes: 1 addition & 1 deletion dbtsl/api/shared/query_params.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ class GroupByParam:

name: str
type: GroupByType
grain: Optional[str]
grain: Optional[str] = None


@dataclass(frozen=True)
Expand Down
5 changes: 5 additions & 0 deletions tests/query_test_cases.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,4 +51,9 @@
GroupByParam(name="metric_time", grain="week", type=GroupByType.DIMENSION),
],
},
# group by param object without grain (categorical dimension)
{
"metrics": ["order_total"],
"group_by": [GroupByParam(name="business_owner__acquisition_channel", type=GroupByType.DIMENSION)],
},
]
Loading