Repository navigation
more integration tests - #5
Merged
Merged
Conversation
generates a throwaway rsa key in an isolated GNUPGHOME, encrypts a plaintext with cipher, then decrypts the bytes and checks they match. skips when gpg is not on path.
new integration build tag test that encrypts and decrypts a yaml through cipher and the kms provider. CI runs it against a fresh localstack container with the KMS service enabled. local runs can target real aws or a localstack instance the same way by setting CIPHER_TEST_KMS_ARN. integration workflow now has three jobs. vault was already there. pgp uses the runner gpg binary in a temp GNUPGHOME. kms uses localstack for offline runs.
the latest tag started asking for a pro license. v3 is the last fully community image and still has the kms service we need.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two more backends now have real round trip coverage.
pgp uses the runner gpg binary inside a temp GNUPGHOME so the test never touches the caller keyring. Generates a 2048 bit rsa key, encrypts a plaintext, decrypts the bytes, and checks they match.
aws kms runs against a fresh localstack container. CI creates a kms key inside it via the aws cli, exports the arn, and the test encrypts and decrypts through cipher. Local runs can target real aws or a localstack instance the same way by setting CIPHER_TEST_KMS_ARN.
Integration workflow now has three jobs side by side. vault was already there.
gcp kms and azure key vault do not have stable open source emulators so they stay covered by the shape and identity format tests for now.