Repository navigation
fix: do not add licence acceptance to compose files silently - #10
Merged
Merged
Conversation
Make the rule explicit in SKILL.md, comment out the acceptance lines in the compose example, and make the credentials eval fail when --accept-license or the 10.x terms are added without flagging them as the user's decision. Co-Authored-By: Claude Code <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SKILL.mdBoundaries: licence/terms acceptance (SPLUNK_START_ARGS: --accept-license,SPLUNK_GENERAL_TERMSon 10.x) is the user's decision; leave the lines out unless they have said they accept, and say the container will not start without them.references/docker-compose.md: the compose example now has those lines commented out, and the note matches the rule. Previously the example included them, which contradicted "do not add silently" and led simulated agents to add--accept-license.evals.json:credentials_never_in_chatnow fails if the compose file includes the acceptance lines without flagging them.No version bump or changelog entry (skill text only); can be rolled into the next release.
Test plan
python3 -m unittest discover -s tests(149 tests, OK)🤖 Generated with Claude Code