Repository navigation
Add --image and --cloud, fix Kubernetes claim, verify Docker docs (2.2.0) - #5
Merged
Merged
Conversation
…s (2.2.0) --image reads the Splunk version from a container image tag so it no longer has to be passed twice; --cloud restricts the pick to Splunk Cloud compatible releases and the JSON output reports cloud_compatible. Both scripts, with contract tests run against each. The description claimed Kubernetes support, but the Splunk Operator installs apps from object storage, so the claim is removed and routed away. The Docker reference is re-verified against docker-splunk, Docker Hub and the operator docs: SPLUNK_GENERAL_TERMS is only required from 10.x images, and only linux/amd64 is published. Co-Authored-By: Claude Code <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--image REFreads the Splunk version from a container image tag (splunk/splunk:9.4.2,10.6.1-rhel9, registry ports, digests).latest, untagged images and unexpanded variables warn and skip the compatibility check; combining it with--splunk-versionis a usage error. Prints anote:naming the version it used.--cloudonly picks releases marked Splunk Cloud compatible; JSON output gainscloud_compatible(true/false/null). Implemented in both the Python and bash scripts.SKILL.md,metadata.splunk.not-forand the Docker reference.SPLUNK_GENERAL_TERMSis only required from 10.x images (9.x does not check it), onlylinux/amd64is published, comma-separatedSPLUNK_APPS_URLand the two credential variables are confirmed. An unverified@splunk.comlogin claim was removed. Sources added toreferences/sources.md.Test plan
python3 -m unittest discover -s tests: 124 tests, 7 live ones skippedlatest/untagged/variable, usage error,-q)select_release(cloud_only=...)SPLUNKBASE_LIVE=1live tests pass against the real API, including a new check thatcloud_compatibleis a boolean/bin/bash3.2🤖 Generated with Claude Code