Skip to content

Commit c3ef378

Browse files
fix(skills): align runtime and input validation guidance
ACK: keep the training command as dp because DP-GEN appends backend flags; accept NumPy directories or HDF5 init data; qualify descriptor spelling by installed backend; remove the assets layout assumption; and add an explicit post-iteration monitoring stage. NAK: the older findings about list numbering, TensorFlow-only wording, empty systems syntax, missing confirmation, absent resources, remote_root and batch casing requirements, link containment, and weak machine-field assertions are already resolved in the current tree, so no duplicate changes are needed.
1 parent c782046 commit c3ef378

3 files changed

Lines changed: 17 additions & 9 deletions

File tree

skills/dpgen-run/SKILL.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,5 +36,5 @@ Use this skill for the iterative train, explore, label, and retrain workflow.
3636

3737
- Never merge the JSON files or invent paths, queues, modules, or commands.
3838
- Preserve descriptor, backend, thresholds, schedules, ensemble, and `type_map` choices.
39-
- Spell `se_atten_v2` exactly; `fp_style: "none"` is invalid for current `dpgen run`.
39+
- Check `se_atten_v2` against the installed backend; `fp_style: "none"` is invalid.
4040
- Stop and ask when required scientific or execution inputs are undiscoverable.

skills/dpgen-run/references/validation-and-run.md

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,13 +19,15 @@ DP-GEN can fill it from `init_data_sys`. Verify `deepmd_version` and the
1919
installed stack before using version-specific descriptors or features.
2020

2121
`train_backend` accepts `tensorflow` and `pytorch`, but compatibility still
22-
depends on the installed DeePMD-kit and descriptor. Verify the combination;
23-
spell `se_atten_v2` exactly. Ordinary LAMMPS exploration uses the default
22+
depends on the installed DeePMD-kit and descriptor. Verify descriptor spelling
23+
against that backend; current releases register `se_atten_v2`.
24+
Ordinary LAMMPS exploration uses the default
2425
`model_devi_engine`; set an alternative only when verified. Current `dpgen run`
2526
does not accept `fp_style: "none"`.
2627

27-
Each `init_data_sys` directory must contain `type_map.raw`, `type.raw`, and
28-
`set.000/`; every `type_map.raw` must match `param.json.type_map` exactly.
28+
Each `init_data_sys` entry may be a DeepMD NumPy system directory or an HDF5
29+
file. Each NumPy directory must contain at least `type.raw` and `set.000/`.
30+
When `type_map.raw` is present, it must match `param.json.type_map` exactly.
2931

3032
## 2. `machine.json` essentials
3133

@@ -38,8 +40,8 @@ for generic local, scheduler, and SSH shapes.
3840

3941
The launcher shell and dispatched tasks are different environments. Scheduler
4042
jobs must activate their own runtime through `source_list`; outer activation is
41-
not inherited reliably. The training command must select the same backend as
42-
`train_backend` (for DeePMD-kit 3.x PyTorch this may be `dp --pt`). Validate
43+
not inherited reliably. Keep the training command as `dp`; DP-GEN appends
44+
backend flags such as `--pt` or `--jax` from `train_backend`. Validate
4345
commands, context types, batch aliases, roots, and resources against installed
4446
DPDispatcher rather than normalizing by assumption.
4547

skills/dpgen-run/references/workflow.md

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,12 @@ contexts, and resources, and `dpgen run param.json machine.json` as the launcher
1717
Preparation needs Python and DP-GEN. Execution also needs DeePMD-kit, the
1818
exploration engine, the selected FP software, and any scheduler runtime.
1919

20+
## Monitoring stage
21+
22+
After each iteration, record RMSE, model-deviation, and FP outcomes by system
23+
and condition. Use [monitoring guidance](monitoring.md) before changing settings
24+
or restarting a stalled iteration.
25+
2026
## Preparation policy
2127

2228
Inspect existing configuration files, training inputs, dataset metadata, and
@@ -38,12 +44,12 @@ project/
3844
|-- machine.json
3945
|-- init_data/
4046
| `-- raw_xxx/ # DeepMD NumPy system(s)
41-
|-- assets/ # structures and runtime support files
47+
|-- inputs/ # optional structures and backend inputs
4248
`-- iter.*/ # created by DP-GEN
4349
```
4450

4551
Keep repeated experiments in separate, clearly named directories derived from a
46-
reviewed base configuration. Backend-specific files belong under `assets/` or
52+
reviewed base configuration. Backend-specific files belong under `inputs/` or
4753
the path explicitly required by the selected backend.
4854

4955
## Reporting contract

0 commit comments

Comments
 (0)