[maxdswain]

Related Issues

• fixes Add optional failure recovery for bad PDFs in OpenDataLoaderConverter #4146

Proposed Changes:

Add optional batch bisection to skip bad PDFs to prevent conversion failures from a single bad PDF.

How did you test it?

Added unit and integration tests.

Notes for the reviewer

Checklist

• I have read the contributors guidelines and the code of conduct
• I have updated the related issue with new insights and changes
• I added unit tests and updated the docstrings
• I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test:.

[github-actions]

Hi @maxdswain, thanks for your interest in contributing to Haystack! 🙏

⚠️ You currently have 3 open pull requests in this repository (#4048, #4014 and this one). Our review capacity is limited, so please hold off opening more PRs until we've had a chance to review your first 2 open PRs. This helps us give each contribution the attention it deserves. Thank you!

This is an automated message to help us keep the review queue healthy.

[github-actions]

Coverage report (opendataloader_pdf)

Click to see where and how coverage changed

File	Statements	Missing	Coverage	Coverage (new stmts)	Lines missing
integrations/opendataloader_pdf/src/haystack_integrations/components/converters/opendataloader_pdf
converter.py
Project Total

This report was generated by python-coverage-comment-action

[julian-risch]

Thank you @maxdswain . Looks quite good to me already. One suggestion for a change. Other than that I am ready to approve the PR.

[maxdswain]

Hi @julian-risch I've addressed all of your review comments, this should be ready to be merged.