Repository navigation
Conversation
Contributor
Coverage report (pgvector)Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||
Contributor
Contributor
31groot
force-pushed
the
feat/pgvector-zero-downtime-replacement
branch
from
October 26, 2026 13:12
e0f3fba to
b7d8f31
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes
The goal is to reduce downtime when replacing Pgvector tables while preserving the previous table as a backup.
Limitation: Writers should be paused during the cutover. This implementation reduces replacement downtime but does not guarantee uninterrupted concurrent writes.
How did you test it?
Ran the following commands from
integrations/pgvectorwith a local Pgvector PostgreSQL instance:hatch run fmt src/haystack_integrations/document_stores/pgvector/table_replacement.py tests/test_table_replacement.pyhatch run fmt-check src/haystack_integrations/document_stores/pgvector/document_store.py src/haystack_integrations/document_stores/pgvector/table_replacement.py tests/test_table_replacement.pyhatch run test:integration tests/test_table_replacement.py— 5 passedhatch run test:integration tests/test_document_store.py— 57 passed, 2 skippedhatch run test:integration tests/test_document_store_async.py— 53 passed, 2 skippedhatch run test:types— passedgit diff --check— passedNotes for the reviewer
Checklist
feat:.