[muthukkumaranb]

Related Issues

• fixes LaraDocumentTranslator ignores falsy run() overrides (reasoning=False, glossaries=[]) #4168

Proposed Changes:

LaraDocumentTranslator.run() resolved run-time overrides with x or self.x, so falsy values such as reasoning=False, glossaries=[] and adapt_to=[] were silently replaced by the init values.

All run-time parameters now use x if x is not None else self.x, so only None falls back to the init value.

How did you test it?

Added test_run_falsy_overrides_from_init: it initializes the translator with reasoning=True, glossaries and adapt_to, calls run(reasoning=False, glossaries=[], adapt_to=[]) with a mocked Lara client, and checks that the falsy values reach translate(). The test fails before the change and passes after.

Ran hatch run test:unit locally (23 passed) and ruff check / ruff format.

Notes for the reviewer

Same pattern as #4084 and #4159.

Checklist

• I have read the contributors guidelines and the code of conduct
• I have updated the related issue with new insights and changes
• I added unit tests and updated the docstrings
• I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test:.

[github-actions]

Heads-up for maintainers

This PR is from a fork and touches integrations whose integration tests require API keys.
Those tests are skipped in CI because fork PRs don't have access to repo secrets for security reasons.

Affected integrations:

• lara

Please run the integration tests locally (hatch run test:integration inside each folder) before approving.

[github-actions]

Coverage report (lara)

Click to see where and how coverage changed

File	Statements	Missing	Coverage	Coverage (new stmts)	Lines missing
integrations/lara/src/haystack_integrations/components/translators/lara
document_translator.py
Project Total

This report was generated by python-coverage-comment-action

[HaystackBot]

Hi @muthukkumaranb, thanks a lot for your contribution! 🙏

We noticed that the Contributor License Agreement (CLA) check (license/cla) hasn't passed yet, so we've temporarily moved this PR to draft and paused the review assignment.

To get your PR reviewed, please sign the CLA via the link in the license/cla check below (or in the CLA bot comment). As soon as the check turns green, this PR will automatically be marked ready for review again and a reviewer will be re-assigned.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[HaystackBot]

Thanks for signing the CLA, @muthukkumaranb! 🎉 This PR is now ready for review again and the reviewer has been re-assigned.

[julian-risch]

Thank you @muthukkumaranb !