Repository navigation
fix(monty): update default description and tests for pydantic-monty 1.4.0 (decimal support) - #4170
Merged
Merged
Conversation
….4.0 (decimal support)
Contributor
Coverage report (monty)
This PR does not seem to contain any modification to coverable code. |
davidsbatista
marked this pull request as ready for review
October 28, 2026 15:06
davidsbatista
requested review from
julian-risch
and removed request for
a team
October 28, 2026 15:06
julian-risch
approved these changes
Oct 29, 2026
julian-risch
left a comment
julian-risch
left a comment
Member
There was a problem hiding this comment.
Looks good. Please also do a small docs update in the haystack repo.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes:
pydantic-monty1.4.0 added thedecimalmodule. Because our dependency only sets a minimum, CI installs 1.4.0, andtest_unlisted_modules_are_not_importable[decimal]now fails: that test exists to flag when Monty supports a new module, so the tool description can be updated.Same approach as #4155 did for
bisectin 1.3.0:decimalto the importable modules listed in the default tool descriptiondecimalfrom the not-importable test casespydantic-monty>=1.4.0, so the description doesn't list a module that older versions can't importHow did you test it?
hatch run test:unitpasses (43 tests) withpydantic-monty1.4.0decimaland 1.4.0 can (Decimal('0.1') + Decimal('0.2')returnsDecimal('0.3'))hatch run fmt-checkandhatch run test:typesare clean