Repository navigation
fix: qdrant - apply scale_score to grouped results and fix write progress bar - #4171
Goodnight77 wants to merge 4 commits into
Conversation
Coverage report (qdrant)Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
|
Hi @Goodnight77, thanks a lot for your contribution! 🙏 We noticed that the Contributor License Agreement (CLA) check ( To get your PR reviewed, please sign the CLA via the link in the |
|
@cla-assistant check |
|
Thanks for signing the CLA, @Goodnight77! 🎉 This PR is now ready for review again and the reviewer has been re-assigned. |
|
@CLAassistant check |
|
Thanks for signing the CLA, @Goodnight77! 🎉 This PR is now ready for review again and the reviewer has been re-assigned. |
Related Issues
None, found while reading the Qdrant document store code.
Proposed Changes:
Two small fixes in QdrantDocumentStore.
scale_score was ignored when group_by was set. The dense and sparse query paths (sync and async) passed grouped results to _process_group_results, which never applied score scaling, so users got raw scores back even with scale_score=True. _process_group_results now takes scale_score, flattens the group hits and reuses _process_query_point_results, so grouped and non-grouped queries scale scores the same way.
The write progress bar overcounted. write_documents and write_documents_async advanced the bar by write_batch_size on every batch, including the last partial one, so writing 2 documents showed 100 items. The bar now advances by the actual batch length.
How did you test it?
Notes for the reviewer
Hybrid retrieval is unchanged since it has no scale_score parameter.
Checklist