Repository navigation
fix(transformers): respect zero stride override in TransformersExtractiveReader - #4177
Open
muthukkumaranb wants to merge 3 commits into
Open
muthukkumaranb wants to merge 3 commits into
muthukkumaranb wants to merge 3 commits into
Conversation
muthukkumaranb
requested review from
julian-risch
and removed request for
a team
October 30, 2026 17:11
Contributor
|
Heads-up for maintainers This PR is from a fork and touches integrations whose integration tests require API keys. Affected integrations:
Please run the integration tests locally ( |
Contributor
Coverage report (transformers)Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
TransformersExtractiveReader.run()resolved thestrideoverride withstride or self.stride, so an explicitstride=0(no overlap between split sequences) was silently replaced by the init value. It now falls back only whenstrideisNone.This follows up on #4159, which fixed the same pattern for
score_thresholdandoverlap_thresholdin the same method and noted thatstride=0was left out to keep that change small.How did you test it?
test_run_respects_zero_stride_override: sets the init stride to 64, callsrun(..., stride=0)and asserts_preprocessreceivesstride=0. It fails onmain(assert 64 == 0) and passes with the fix.pytest -m "not integration" tests/test_extractive_reader.py: 39 passed.ruff checkandruff format --checkpass.Notes for the reviewer
One-line change. The remaining
orfallbacks inrun()(top_k,max_seq_length,max_batch_size,answers_per_seq) are left unchanged since0is not a meaningful value for them.Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.