[mmporong]

Related Issues

• No existing issue that I could find.

Proposed Changes:

_create_where_document_filter decides whether a logical filter is a content filter by looking only at its first condition (value[0]). For an AND that mixes a content condition and a metadata condition, the result depends on the order:

• metadata condition first: the whole $and goes to Chroma's where, so content is treated as a metadata key and the filter silently matches nothing;
• content condition first: every condition is converted as a document filter, and the metadata one makes the filter fail with ChromaDocumentStoreFilterError: Invalid 'document content filter' : Expected where document to have exactly one operator.

In Haystack's filter syntax the order of AND conditions does not matter. Chroma applies where and where_document together, so _convert_filters now sends the content conditions of a top-level AND to where_document and the other conditions to where, in either order. If the non-content part itself contains a content condition (for example nested under OR), the previous code path is used unchanged.

How did you test it?

• New unit tests in tests/test_filters.py: the mixed AND in both orders, and one content condition with two metadata conditions. All three fail before the change and pass after it.
• pytest tests -m "not integration" in integrations/chroma: 56 passed (53 passed and 3 failed before).
• With a real in-memory ChromaDocumentStore and three documents, filter_documents with content contains "x" AND meta.a == 1 returned [] (metadata first) or raised (content first) before the change, and returns the matching document in both orders after it. I did not run the integration-marked tests.
• ruff check and ruff format --check pass on the changed files.

Notes for the reviewer

Open PRs #4124 (metadata id filters) and #3797 (empty filter conditions) touch the same module but different cases. An OR that mixes content and metadata conditions cannot be expressed with Chroma's two separate clauses and is not changed here.

Checklist

• I have read the contributors guidelines and the code of conduct
• I have updated the related issue with new insights and changes
• I added unit tests and updated the docstrings
• I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test:.

[github-actions]

Coverage report (chroma)

Click to see where and how coverage changed

File	Statements	Missing	Coverage	Coverage (new stmts)	Lines missing
integrations/chroma/src/haystack_integrations/document_stores/chroma
filters.py
Project Total

This report was generated by python-coverage-comment-action