-
Notifications
You must be signed in to change notification settings - Fork 3.1k
feat: DocumentSplitter — add split_by="token" mode using tiktoken #12529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rautaditya2606
wants to merge
9
commits into
deepset-ai:main
Choose a base branch
from
rautaditya2606:feat/document-splitter-token
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
79cc237
feat: add split_by='token' to DocumentSplitter
rautaditya2606 3d2e372
feat: address PR review feedback for split_by='token' in DocumentSpli…
rautaditya2606 5d4c1dd
test: fix mypy type narrowing assertions in test_document_splitter
rautaditya2606 fbc30e9
feat: use decode_with_offsets and support token mode in DocumentPrepr…
rautaditya2606 e19a3d2
refactor: address review comments for token splitting tests and bounds
rautaditya2606 d60c42c
test: add test case for overlap_start boundary condition
rautaditya2606 394aee1
ci: re-trigger CI
rautaditya2606 00f1a62
test: add page tracking integration tests for token splitting
rautaditya2606 67530c4
Merge branch 'main' into feat/document-splitter-token
rautaditya2606 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 8 additions & 0 deletions
8
releasenotes/notes/document-splitter-split-by-token-8a3f69718d05dfad.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| --- | ||
| enhancements: | ||
| - | | ||
| Add ``split_by="token"`` to ``DocumentSplitter``. Splits text by LLM token | ||
| count using tiktoken. The encoding defaults to ``"o200k_base"`` (current | ||
| OpenAI models) and can be changed via the new ``tokenizer_encoding`` | ||
| parameter. ``split_length``, ``split_overlap``, and ``split_threshold`` all | ||
|
anakin87 marked this conversation as resolved.
Outdated
|
||
| work as usual. Requires ``pip install tiktoken``. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.