Fix catalog matching for partially specified source presets

Author: defencore

src/core/preset-search.ts

@@ -160,6 +160,13 @@ export function getFilterFields(parts: PartDefinition[]): PresetFilterField[] {
 
 export function seedCurrentFilters(part: PartDefinition, parameters: Parameters): PresetFilters {
   const filters = emptyPresetFilters(part);
+  const currentPreset =
+    part.presets.find((preset) => preset.catalog && preset.parameters === parameters) ??
+    part.presets.find(
+      (preset) =>
+        preset.catalog &&
+        part.parameters.every((field) => preset.parameters[field.key] === parameters[field.key]),
+    );
   const keys =
     part.presetMatchKeys ??
     part.parameters
@@ -170,6 +177,15 @@ export function seedCurrentFilters(part: PartDefinition, parameters: Parameters)
     if (field.filterable === false) continue;
     if (!keys.includes(field.key) || (field.visibleWhen && !field.visibleWhen(parameters)))
       continue;
+    // An exact catalog configuration also contains editable prototype dimensions.
+    // Do not turn those assumptions into automatic catalog requirements.
+    if (
+      currentPreset?.catalog &&
+      field.type === 'number' &&
+      !currentPreset.catalog.verifiedParameters.includes(field.key) &&
+      !getPresetParameterRange(currentPreset, field.key)
+    )
+      continue;
     const value = parameters[field.key];
     if (field.type === 'number' && typeof value === 'number' && Number.isFinite(value)) {
       filters.parameters[fieldId(field)] = { min: String(value), max: String(value) };

tests/preset-search.test.ts

@@ -309,6 +309,30 @@ test('current-parameter matching is opt-in and ignores hidden or invalid fields'
   );
 });
 
+test('exact catalog matching skips assumed dimensions while custom matching preserves requested values', () => {
+  const preset: Preset = {
+    id: 'nominal-only',
+    name: 'Nominal bore reference',
+    description: 'Width is an editable prototype assumption.',
+    parameters: { bore: 20, width: 14 },
+    catalog: { ...source, verifiedParameters: ['bore'] },
+  };
+  const configurable = {
+    ...part('reference', [bore, width], [preset]),
+    defaults: { ...preset.parameters },
+    presetMatchKeys: ['bore', 'width'],
+  };
+  for (const values of [preset.parameters, { ...preset.parameters }]) {
+    const filters = seedCurrentFilters(configurable, values);
+    assert.deepEqual(filters.parameters[boreId], { min: '20', max: '20' });
+    assert.equal(filters.parameters[fieldId(width)], undefined);
+    assert.equal(filterPresets(buildPresetIndex([configurable]), filters).items[0].preset, preset);
+  }
+  const custom = seedCurrentFilters(configurable, { ...preset.parameters, width: 16 });
+  assert.deepEqual(custom.parameters[fieldId(width)], { min: '16', max: '16' });
+  assert.equal(filterPresets(buildPresetIndex([configurable]), custom).items.length, 0);
+});
+
 test('a hidden conditional parameter never matches an inactive preset feature', () => {
   const socket: ParameterDefinition = {
     key: 'socketDepth',