Repository navigation
[Spark] Add AMT variants of the DELETE test suites - #7849
Merged
murali-db merged 2 commits intoOct 15, 2026
Merged
Conversation
… tests - Move the rule that unsets a suite's `delta.enableDeletionVectors = false` default for new tables from the UPDATE and DELETE AMT bases into `AMTDMLTestUtils`. When it applies, keep DELETE, UPDATE and MERGE from writing persistent deletion vectors, so tests that predict file rewrites from that default still hold. - The DELETE schema pruning tests now only collect scans over a `TahoeFileIndex`, which skips the AMT tree read, so the AMT DELETE suites no longer exclude them.
ctring
approved these changes
Oct 14, 2026
murali-db
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
Adds
DeleteAMTandRowTrackingDeleteAMTdimensions to the delta-suite-generator, plus a generateddeleteamtgroup that runs the DELETE tests against AMT (adaptiveMetadata-preview) tables, following the UPDATE AMT suites.DeleteAMTMixinbrackets eachexecuteDeletewith theAMTDMLTestUtilscheckpoints.RowTrackingDeleteAMTMixinbrackets each test table's body instead, since its row tracking checks inspect the latest commit.AMTDMLTestUtilsnow unsets a suite'sdelta.enableDeletionVectors = falsedefault for new tables for all AMT DML suites (moved from the UPDATE AMT base), and keeps DELETE, UPDATE and MERGE from writing deletion vectors where the tests assert file rewrites.TahoeFileIndex, so they skip the checkpoint's tree read.RowTrackingDeleteDvBaseis not generated, since its only test disables deletion vectors on new tables.How was this patch tested?
Test-only change. The new generated
deleteamtsuites run the existing DELETE tests on AMT tables.Does this PR introduce any user-facing changes?
No.