feature: Add curseforge support as curserinth has 20 item limit and unmaintained - #136
Conversation
|
Note this PR needs to be revised if #135 lands first. |
I asked @kuylar and she said the API key is... from the CurseForge App. If we use it we will most likely violate their ToS. |
Last time I checked you'd be waiting for months to get an API key, if you ever get a response at all. I don't know if this has changed however, I haven't touched CF in 2 years. If it was me, I would get an API key from CF (hopefully) but allow overrides through an environment variable or a local file. Regarding why CR had a hardcoded 20 versison limit: Modrinth's API doesn't have pagination in the project versions endpoint (docs), so my options were to either Though, looks like Modrinth has added game version & loader type filters in their version listing endpoint (still no pagination! john modrinth, please...) so I may end up throwing a small patch to add that to CR re: why i had the api key in my code but telling others not to have it: the file the key was in ( |
dc032ee to
0887ac8
Compare
|
I revised after #135 merged to update with |
|
lgtm |
I'm new to Minecraft modding and not sure if there's politics or policies involved why we can't implement Curseforge. Let me know, I used the API key that Curserinth is using.
I introduced an env var to switch to curseforge:
I'm having trouble
mcman buildfor Raspberry Flavoured which includes a mod of an older MC version. Curserinth limits at 20 items in their implementation: https://github.com/kuylar/curserinth/blob/7fbc142484ca9ca178bfa44dfc6658cd767c2370/CurseRinth/Controllers/V2/VersionsController.cs#L36If there's no issues, maybe we should just default to the curseforge implementation and keep
curserinth.rsaround for backwards compatibility (and remove theMCMAN_USE_CURSEFORGEenv var).So this will fail:
But this will succeed with this PR: