fix: linter fortitude: renamed location key from "row" to "line" - #5161
Open
gomfol12 wants to merge 3 commits into
Open
fix: linter fortitude: renamed location key from "row" to "line"#5161gomfol12 wants to merge 3 commits into
gomfol12 wants to merge 3 commits into
Conversation
hsanson
requested changes
Aug 19, 2026
hsanson
left a comment
hsanson
left a comment
Contributor
There was a problem hiding this comment.
This looks like a very recent breaking change on fortitude side. I recommend we keep support for the previous 'row' as removing it may break this linter for users that are stuck with previous versions of the linter. Keep the tests using 'row' intact and add a new set of test for 'line'.
Contributor
Author
|
Yes makes sense. I now test for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
fortitude has renamed the key
rowtolinein thelocationandend_locationfield. They changed it in this commit PlasmaFAIR/fortitude@0eda119.This PR fixes this.