Skip to content

Commit 3328283

Browse files
author
Saurabh Kumar Bajpai
committed
fix: add .catch() to promise chains
1 parent af173a5 commit 3328283

2 files changed

Lines changed: 12 additions & 12 deletions

File tree

‎frontend/js/app.js‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@ const CollectionAPI = {
152152
method: 'POST',
153153
headers: this.getHeaders(),
154154
credentials: 'include',
155-
body: JSON.stringify({ user_id: parseInt(userId), name, description, is_public: isPublic })
155+
body: JSON.stringify({ user_id: parseInt(userId, 10), name, description, is_public: isPublic })
156156
});
157157
if (!res.ok) {
158158
const errData = await res.json().catch(() => ({}));
@@ -222,7 +222,7 @@ const CollectionAPI = {
222222
headers: this.getHeaders(),
223223
credentials: 'include',
224224
body: JSON.stringify({
225-
user_id: parseInt(userId),
225+
user_id: parseInt(userId, 10),
226226
google_books_id: bookId,
227227
title: title,
228228
authors: Array.isArray(authors) ? authors.join(', ') : authors,
@@ -939,7 +939,7 @@ class BookRenderer {
939939
const slider = scene.querySelector('.progress-slider');
940940
if (slider) {
941941
slider.addEventListener('change', (e) => {
942-
const newProgress = parseInt(e.target.value);
942+
const newProgress = parseInt(e.target.value, 10);
943943
if (this.libraryManager) {
944944
this.libraryManager.updateBook(id, { progress: newProgress });
945945
}
@@ -3483,7 +3483,7 @@ document.addEventListener('DOMContentLoaded', async () => {
34833483

34843484
if (saveGoalBtn) {
34853485
saveGoalBtn.addEventListener('click', async () => {
3486-
const target = parseInt(goalInput.value);
3486+
const target = parseInt(goalInput.value, 10);
34873487
if (isNaN(target) || target < 1) return;
34883488

34893489
const token = SafeStorage.get('bibliodrift_token');
@@ -3782,13 +3782,13 @@ document.addEventListener('DOMContentLoaded', async () => {
37823782
const saveBtn = card.querySelector('.progress-card-save-btn');
37833783

37843784
slider.addEventListener('input', () => {
3785-
const val = parseInt(slider.value);
3785+
const val = parseInt(slider.value, 10);
37863786
barFill.style.width = `${val}%`;
37873787
pctLabel.textContent = `${val}%`;
37883788
});
37893789

37903790
saveBtn.addEventListener('click', async () => {
3791-
const newProgress = parseInt(slider.value);
3791+
const newProgress = parseInt(slider.value, 10);
37923792
saveBtn.disabled = true;
37933793
saveBtn.innerHTML = '<i class="fa-solid fa-spinner fa-spin"></i>';
37943794
try {

‎frontend/js/library-3d.js‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2407,7 +2407,7 @@ class BookshelfRenderer3D {
24072407
if (progressBadge) progressBadge.textContent = `${clamped}% `;
24082408
// Sync pages input
24092409
if (pagesReadInput && pagesTotalInput) {
2410-
const pages = Math.round((clamped / 100) * parseInt(pagesTotalInput.value || totalPages));
2410+
const pages = Math.round((clamped / 100) * parseInt(pagesTotalInput.value || totalPages, 10));
24112411
pagesReadInput.value = pages;
24122412
}
24132413
if (pagesBar) pagesBar.style.width = `${clamped}% `;
@@ -2450,12 +2450,12 @@ class BookshelfRenderer3D {
24502450
progressSlider.parentNode.replaceChild(newSlider, progressSlider);
24512451
newSlider.value = currentProgress;
24522452
newSlider.addEventListener('input', () => {
2453-
const pct = parseInt(newSlider.value);
2453+
const pct = parseInt(newSlider.value, 10);
24542454
if (progressBar) progressBar.style.width = `${pct}% `;
24552455
if (progressValue) progressValue.textContent = `${pct}% `;
24562456
if (progressBadge) progressBadge.textContent = `${pct}% `;
24572457
// Sync pages
2458-
const total = parseInt(document.getElementById('modal-pages-total')?.value || totalPages);
2458+
const total = parseInt(document.getElementById('modal-pages-total', 10)?.value || totalPages);
24592459
const pages = Math.round((pct / 100) * total);
24602460
const pagesReadEl = document.getElementById('modal-pages-read');
24612461
if (pagesReadEl) pagesReadEl.value = pages;
@@ -2469,8 +2469,8 @@ class BookshelfRenderer3D {
24692469
const pagesTotalEl = document.getElementById('modal-pages-total');
24702470
const sliderEl = document.getElementById('modal-progress-slider');
24712471
if (!pagesReadEl || !pagesTotalEl) return;
2472-
const read = Math.max(0, parseInt(pagesReadEl.value) || 0);
2473-
const total = Math.max(1, parseInt(pagesTotalEl.value) || 1);
2472+
const read = Math.max(0, parseInt(pagesReadEl.value, 10) || 0);
2473+
const total = Math.max(1, parseInt(pagesTotalEl.value, 10) || 1);
24742474
const pct = Math.min(100, Math.round((read / total) * 100));
24752475
if (sliderEl) sliderEl.value = pct;
24762476
if (progressBar) progressBar.style.width = `${pct}% `;
@@ -2497,7 +2497,7 @@ class BookshelfRenderer3D {
24972497
progressSaveBtn.parentNode.replaceChild(newSaveBtn, progressSaveBtn);
24982498
newSaveBtn.addEventListener('click', async () => {
24992499
const sliderEl = document.getElementById('modal-progress-slider');
2500-
const newProgress = sliderEl ? parseInt(sliderEl.value) : currentProgress;
2500+
const newProgress = sliderEl ? parseInt(sliderEl.value, 10) : currentProgress;
25012501

25022502
newSaveBtn.disabled = true;
25032503
newSaveBtn.innerHTML = '<i class="fa-solid fa-spinner fa-spin"></i> Saving...';

0 commit comments

Comments
 (0)