Skip to content

Title: feat: Add Book Club Discussion Forum - Community discussions for books #716 - #1085

Closed
aarushii25 wants to merge 5 commits into
devanshi14malhotra:mainfrom
aarushii25:feature/discussion-forum-716
Closed

aarushii25 wants to merge 5 commits into
devanshi14malhotra:mainfrom
aarushii25:feature/discussion-forum-716

Conversation

@aarushii25

@aarushii25 aarushii25 commented May 28, 2026 •

Copy link
Copy Markdown

hi @devanshi14malhotra

Description:

Related Issue
Fixes #716

Description
Implemented the Book Club Discussion Forum to allow readers to interact, share thoughts, and discuss theories about their favorite books. The UI has been carefully designed to match BiblioDrift's existing Dark Academia / Glassmorphism theme.

Changes Made:
New Pages: Created discuss.html and discussion.js.

Data Storage: Implemented localStorage to handle demo data for posts, likes, and comments.

UI/UX Matching:

Integrated the standard BiblioDrift header and background glow effects.

Used CSS variables (var(--accent-gold), var(--card-bg), etc.) to ensure seamless theme integration.

Iconography: Replaced standard emojis with Font Awesome Icons throughout the discussion page for a cleaner, cross-platform professional look as requested.

Button Integration: Added the "Discuss" button to:

The 3D Book Cards on the front-end (via app.js).

The Book Details Modal (via index.html).

Bonus Enhancement: Implemented URL parameter parsing (?title=...) so that clicking "Discuss" on a specific book automatically pre-fills the discussion form with the correct book title.

Tech Stack
HTML5, CSS3

Vanilla JavaScript (localStorage)

Font Awesome

Screenshot 2026-05-28 125304 Screenshot 2026-05-28 125321 Screenshot 2026-05-28 125337

@netlify

netlify Bot commented May 28, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for bibliodrift-dm ready!

Name Link
🔨 Latest commit 1d96355
🔍 Latest deploy log https://app.netlify.com/projects/bibliodrift-dm/deploys/6a17efe92c93f80008c0d406
😎 Deploy Preview https://deploy-preview-1085--bibliodrift-dm.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@devanshi14malhotra devanshi14malhotra added the level:beginner GSSoC'26 beginner level PR/issue label May 28, 2026
@devanshi14malhotra

Copy link
Copy Markdown
Owner

@aarushii25
Really appreciate the time you took to build out discuss.html and discuss.js.

Unfortunately, I will have to close this PR because it includes several unrelated, out-of-scope changes that accidentally break existing parts of the application:

-Destructive layout changes in index.html: The PR injects the Book Modal action buttons (modal-actions) directly into an .about-card on the main landing page. This breaks the landing page UI and places book context buttons where there is no book data.
-Unrelated Password Validation Logic: The PR includes backend changes (backend/app.py, backend/validators.py) and frontend changes (auth.html) related to password strength validation. This is out of scope for Issue #716.
-Duplicated Auth UI: The password strength changes injected a raw, unstyled HTML checklist into auth.html right next to our existing styled password strength meter, causing overlapping UI elements.

How to move forward:
We would still love to have your Discussion Forum feature! Please feel free to open a new, clean Pull Request that focuses only on the scope of Issue #716:

-Adding discuss.html and discuss.js
-Adding the "Discuss" button to the book cards in app.html / library.html

Please ensure that your new branch is pulled from the latest main and that no unrelated files (like index.html, auth.html, or backend authentication files) are modified.

Thank you again for your hard work, looking forward to seeing your clean PR!

@devanshi14malhotra devanshi14malhotra removed the level:beginner GSSoC'26 beginner level PR/issue label May 28, 2026
@aarushii25

Copy link
Copy Markdown
Author

Hi @devanshi14malhotra,

Thank you so much for the detailed review and guidance! I completely understand the issue with the previous merge conflicts and unrelated files.

As requested, I have created a fresh, clean Pull Request that strictly focuses on the Book Club Discussion Forum feature without modifying any out-of-scope files.

You can find the new PR here: #1091

Thank you again for your patience and support! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE]:Add Book Club Discussion Forum - Community discussions for books and characters

2 participants