Skip to content

fix: code quality and safety improvements #1446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
saurabhhhcodes wants to merge 1 commit into from
Closed

fix: code quality and safety improvements #1446

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions frontend/js/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ const CollectionAPI = {
method: 'POST',
headers: this.getHeaders(),
credentials: 'include',
body: JSON.stringify({ user_id: parseInt(userId), name, description, is_public: isPublic })
body: JSON.stringify({ user_id: parseInt(userId, 10), name, description, is_public: isPublic })
});
if (!res.ok) {
const errData = await res.json().catch(() => ({}));
Expand Down Expand Up @@ -222,7 +222,7 @@ const CollectionAPI = {
headers: this.getHeaders(),
credentials: 'include',
body: JSON.stringify({
user_id: parseInt(userId),
user_id: parseInt(userId, 10),
google_books_id: bookId,
title: title,
authors: Array.isArray(authors) ? authors.join(', ') : authors,
Expand Down Expand Up @@ -939,7 +939,7 @@ class BookRenderer {
const slider = scene.querySelector('.progress-slider');
if (slider) {
slider.addEventListener('change', (e) => {
const newProgress = parseInt(e.target.value);
const newProgress = parseInt(e.target.value, 10);
if (this.libraryManager) {
this.libraryManager.updateBook(id, { progress: newProgress });
}
Expand Down Expand Up @@ -3483,7 +3483,7 @@ document.addEventListener('DOMContentLoaded', async () => {

if (saveGoalBtn) {
saveGoalBtn.addEventListener('click', async () => {
const target = parseInt(goalInput.value);
const target = parseInt(goalInput.value, 10);
if (isNaN(target) || target < 1) return;

const token = SafeStorage.get('bibliodrift_token');
Expand Down Expand Up @@ -3782,13 +3782,13 @@ document.addEventListener('DOMContentLoaded', async () => {
const saveBtn = card.querySelector('.progress-card-save-btn');

slider.addEventListener('input', () => {
const val = parseInt(slider.value);
const val = parseInt(slider.value, 10);
barFill.style.width = `${val}%`;
pctLabel.textContent = `${val}%`;
});

saveBtn.addEventListener('click', async () => {
const newProgress = parseInt(slider.value);
const newProgress = parseInt(slider.value, 10);
saveBtn.disabled = true;
saveBtn.innerHTML = '<i class="fa-solid fa-spinner fa-spin"></i>';
try {
Expand Down
12 changes: 6 additions & 6 deletions frontend/js/library-3d.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2407,7 +2407,7 @@ class BookshelfRenderer3D {
if (progressBadge) progressBadge.textContent = `${clamped}% `;
// Sync pages input
if (pagesReadInput && pagesTotalInput) {
const pages = Math.round((clamped / 100) * parseInt(pagesTotalInput.value || totalPages));
const pages = Math.round((clamped / 100) * parseInt(pagesTotalInput.value || totalPages, 10));
pagesReadInput.value = pages;
}
if (pagesBar) pagesBar.style.width = `${clamped}% `;
Expand Down Expand Up @@ -2450,12 +2450,12 @@ class BookshelfRenderer3D {
progressSlider.parentNode.replaceChild(newSlider, progressSlider);
newSlider.value = currentProgress;
newSlider.addEventListener('input', () => {
const pct = parseInt(newSlider.value);
const pct = parseInt(newSlider.value, 10);
if (progressBar) progressBar.style.width = `${pct}% `;
if (progressValue) progressValue.textContent = `${pct}% `;
if (progressBadge) progressBadge.textContent = `${pct}% `;
// Sync pages
const total = parseInt(document.getElementById('modal-pages-total')?.value || totalPages);
const total = parseInt(document.getElementById('modal-pages-total', 10)?.value || totalPages);
const pages = Math.round((pct / 100) * total);
const pagesReadEl = document.getElementById('modal-pages-read');
if (pagesReadEl) pagesReadEl.value = pages;
Expand All @@ -2469,8 +2469,8 @@ class BookshelfRenderer3D {
const pagesTotalEl = document.getElementById('modal-pages-total');
const sliderEl = document.getElementById('modal-progress-slider');
if (!pagesReadEl || !pagesTotalEl) return;
const read = Math.max(0, parseInt(pagesReadEl.value) || 0);
const total = Math.max(1, parseInt(pagesTotalEl.value) || 1);
const read = Math.max(0, parseInt(pagesReadEl.value, 10) || 0);
const total = Math.max(1, parseInt(pagesTotalEl.value, 10) || 1);
const pct = Math.min(100, Math.round((read / total) * 100));
if (sliderEl) sliderEl.value = pct;
if (progressBar) progressBar.style.width = `${pct}% `;
Expand All @@ -2497,7 +2497,7 @@ class BookshelfRenderer3D {
progressSaveBtn.parentNode.replaceChild(newSaveBtn, progressSaveBtn);
newSaveBtn.addEventListener('click', async () => {
const sliderEl = document.getElementById('modal-progress-slider');
const newProgress = sliderEl ? parseInt(sliderEl.value) : currentProgress;
const newProgress = sliderEl ? parseInt(sliderEl.value, 10) : currentProgress;

newSaveBtn.disabled = true;
newSaveBtn.innerHTML = '<i class="fa-solid fa-spinner fa-spin"></i> Saving...';
Expand Down