Repository navigation
[NSOC'26][GSSOC'26] Fix(db): Optimize N+1 queries using SQLAlchemy eager loading - #975
Open
diksha78dev wants to merge 2 commits into
Open
diksha78dev wants to merge 2 commits into
diksha78dev wants to merge 2 commits into
Conversation
❌ Deploy Preview for bibliodrift-dm failed. Why did it fail? →
|
diksha78dev
force-pushed
the
fix/issue-880
branch
from
May 24, 2026 12:04
5872b40 to
f71e301
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves the N+1 database query performance issues reported in #880 specifically affecting the collections endpoints.
Changes Made
selectinload(Collection.items)toget_collections()to eagerly load collection items..options(selectinload(Collection.items).joinedload(CollectionItem.book))toget_collection()to eagerly load items and their associated books simultaneously.joinedload(Collection.user)andselectinload(Collection.items)inget_public_collections()to eliminate sequential user lookups in loop iterations.These changes prevent Cartesian explosion while ensuring all necessary related data is fetched in a minimal number of optimized queries.
Closes #880