Skip to content

Commit 73892d9

Browse files
Brooke HamiltonBrooke Hamilton
authored andcommitted
refactor warning
Signed-off-by: Brooke Hamilton <Brooke.Hamilton+microsoft@microsoft.com>
1 parent 34a4b0f commit 73892d9

1 file changed

Lines changed: 11 additions & 12 deletions

File tree

src/spec-node/devContainersSpecCLI.ts

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -231,12 +231,7 @@ async function provision({
231231
'include-merged-configuration': includeMergedConfig,
232232
}: ProvisionArgs) {
233233

234-
if (experimentalLockfile) {
235-
process.stderr.write('Warning: --experimental-lockfile is deprecated. Lockfiles are now enabled by default.\n');
236-
}
237-
if (experimentalFrozenLockfile) {
238-
process.stderr.write('Warning: --experimental-frozen-lockfile is deprecated. Use --frozen-lockfile instead.\n');
239-
}
234+
warnDeprecatedLockfileFlags(experimentalLockfile, experimentalFrozenLockfile);
240235
const effectiveFrozenLockfile = frozenLockfile || experimentalFrozenLockfile;
241236

242237
const workspaceFolder = workspaceFolderArg ? path.resolve(process.cwd(), workspaceFolderArg) : undefined;
@@ -608,12 +603,7 @@ async function doBuild({
608603
'frozen-lockfile': frozenLockfile,
609604
'omit-syntax-directive': omitSyntaxDirective,
610605
}: BuildArgs) {
611-
if (experimentalLockfile) {
612-
process.stderr.write('Warning: --experimental-lockfile is deprecated. Lockfiles are now enabled by default.\n');
613-
}
614-
if (experimentalFrozenLockfile) {
615-
process.stderr.write('Warning: --experimental-frozen-lockfile is deprecated. Use --frozen-lockfile instead.\n');
616-
}
606+
warnDeprecatedLockfileFlags(experimentalLockfile, experimentalFrozenLockfile);
617607
const effectiveFrozenLockfile = frozenLockfile || experimentalFrozenLockfile;
618608

619609
const disposables: (() => Promise<unknown> | undefined)[] = [];
@@ -1487,3 +1477,12 @@ async function readSecretsFromFile(params: { output?: Log; secretsFile?: string;
14871477
});
14881478
}
14891479
}
1480+
1481+
function warnDeprecatedLockfileFlags(experimentalLockfile: boolean, experimentalFrozenLockfile: boolean) {
1482+
if (experimentalLockfile) {
1483+
process.stderr.write('Warning: --experimental-lockfile is deprecated. Lockfiles are now enabled by default.\n');
1484+
}
1485+
if (experimentalFrozenLockfile) {
1486+
process.stderr.write('Warning: --experimental-frozen-lockfile is deprecated. Use --frozen-lockfile instead.\n');
1487+
}
1488+
}

0 commit comments

Comments
 (0)