Skip to content

fix: 152 SVG ICONS that might have color confusion when used on the same component #2608 - #2633

Open
Yue-plus wants to merge 12 commits into
devicons:developfrom
Yue-plus:fix/color-confusion
Open

fix: 152 SVG ICONS that might have color confusion when used on the same component #2608#2633
Yue-plus wants to merge 12 commits into
devicons:developfrom
Yue-plus:fix/color-confusion

Conversation

@Yue-plus

@Yue-plus Yue-plus commented Jan 18, 2026 •
edited
Loading

Copy link
Copy Markdown

Fixed 152 SVG ICONS that might have color confusion when used on the same component

Related issues and PR:

@Yue-plus
fix devicons#2608
955999d
@Yue-plus
Add the id attribute prefix to 119 ICONS
fda4d93
@Yue-plus
fix(icons): Fixed the problem of inconsistent xlink:href reference …
435f974 
…ID in SVG files
@Yue-plus
Refactor SVG files for Angular icons
01cd23e 
- Updated angular-original-wordmark.svg to use simplified IDs and removed unnecessary attributes.
- Cleaned up the structure of angular-original.svg for consistency and readability.
@Yue-plus
Compress SVG file to one line
1b5b222
@Yue-plus
Merge branch 'fix2608' of github.com:Yue-plus/devicon into fix/color-…
cf6cc58 
…confusion
@Yue-plus Yue-plus mentioned this pull request Jan 18, 2026
Closed
@Yue-plus

Yue-plus commented Jan 18, 2026

Copy link
Copy Markdown
Author

We need to find a way to automatically check this issue through the workflow. There are another 29 ICONS on the develop branch that have color confusion problems. 😂😂😂

image

@Yue-plus Yue-plus changed the title fix: 123 SVG ICONS that might have color confusion when used on the same component #2608 fix: 152 SVG ICONS that might have color confusion when used on the same component #2608 Jan 18, 2026
Snailedlt and others added 3 commits October 27, 2026 17:40
@Snailedlt
Merge branch 'develop' into fix/color-confusion
e4e7022
@Snailedlt
Merge remote-tracking branch 'upstream/develop' into yue/fix-color-co…
5458570 
…nfusion
@Snailedlt @claude
fix: prefix the remaining SVG ids and repair broken references
30e6309 
- Prefix the ids in the 17 SVGs that still had unprefixed ones (some were
  added to develop after this PR started), with the same function the
  build will use.
- jekyll-original-wordmark: re-prefixed from develop's file; the earlier
  rename left <use xlink:href="#l"/"#E"> pointing at ids that no
  longer existed. Also drop a <use> of #j, which never existed.
- vim-original: drop a meaningless xlink:href on a <path>.

Every changed SVG renders pixel-identical to develop.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Snailedlt

Snailedlt commented Oct 28, 2026

Copy link
Copy Markdown
Collaborator

Prepared by Claude (an AI assistant) on behalf of @Snailedlt.

Thanks for this, @Yue-plus! To get it over the line I pushed two commits to your branch:

  • Merged the latest develop, so the icons added since (and the CI fixes) are included.
  • Prefixed the ids in the 17 SVGs that still had unprefixed ones, and repaired jekyll-original-wordmark.svg: its <use xlink:href="#l"> / #E still pointed at the old ids after the rename. Also removed a dangling xlink:href in vim-original.svg.

Every SVG I touched renders pixel-identical to develop, and no SVG in the repo has unprefixed ids or broken references any more.

Next, once the trunk-based migration lands, we'd like to add the automation to this PR too: the check-bot notes unprefixed ids, and the build prefixes them after merge, so this doesn't creep back in.

@Snailedlt
Snailedlt requested review from a team, Snailedlt, Yashh56, canaleal, lunatic-fox and weh and removed request for a team October 28, 2026 13:00
@Snailedlt

Snailedlt commented Oct 28, 2026

Copy link
Copy Markdown
Collaborator

Claude (AI assistant), on behalf of @Snailedlt: Re-checked with the latest develop: all 2137 SVGs have prefixed ids, nothing new to fix. The automation (check-bot warning + prefixing on merge) will be added after the trunk-based migration, since that rewrites the check scripts.

Snailedlt
Snailedlt approved these changes Oct 28, 2026
View reviewed changes

@Snailedlt Snailedlt left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✔️
Thank you for the contribution, and making us aware of this issue! 🙇‍♂️

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Snailedlt Snailedlt Snailedlt approved these changes
@weh weh Awaiting requested review from weh weh was automatically assigned from devicons/devicon__reviewers
@canaleal canaleal Awaiting requested review from canaleal canaleal was automatically assigned from devicons/devicon__reviewers
@lunatic-fox lunatic-fox Awaiting requested review from lunatic-fox lunatic-fox was automatically assigned from devicons/devicon__reviewers
@Yashh56 Yashh56 Awaiting requested review from Yashh56 Yashh56 was automatically assigned from devicons/devicon__reviewers

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Yue-plus @Snailedlt