Skip to content

Commit 9f50ee9

Browse files
authored
Merge pull request #503 from devmount/chores/pnpm-migration
Migrate to pnpm
2 parents 6be94f4 + ebe0269 commit 9f50ee9

5 files changed

Lines changed: 1041 additions & 1723 deletions

File tree

.github/workflows/nightly.yml

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,8 @@ jobs:
1919
runs-on: ubuntu-latest
2020
steps:
2121
- uses: actions/checkout@v6
22-
- name: Use Node.js 22
23-
uses: actions/setup-node@v6
24-
with:
25-
node-version: 22
22+
- name: Setup pnpm
23+
uses: pnpm/action-setup@v6
2624
- name: Compute Filename
2725
id: file
2826
run: |
@@ -38,17 +36,17 @@ jobs:
3836
filename=third-stats_${next}-alpha.${d}.xpi
3937
echo "Built filename is ${filename}"
4038
echo "FILENAME=${filename}" >> $GITHUB_OUTPUT
41-
- name: Build app using NPM
39+
- name: Build app
4240
run: |
43-
npm install
44-
npm run build
41+
pnpm install --frozen-lockfile
42+
pnpm build
4543
- name: Create Thunderbird add-on (.xpi)
4644
shell: bash
4745
run: |
4846
cd dist/
4947
zip -q -r ../${{ steps.file.outputs.FILENAME }} ./
5048
- name: Upload add-on nightly build artifact
51-
uses: actions/upload-artifact@v6
49+
uses: actions/upload-artifact@v7
5250
with:
5351
name: third-stats-nightly
5452
path: ${{ steps.file.outputs.FILENAME }}

README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -75,16 +75,16 @@ If you encounter any problem, please [issue a bug report](https://github.com/dev
7575

7676
### Become a ThirdStats developer
7777

78-
Here is how you can set up a local development environment:
78+
Here is how you can set up a local development environment. This project uses [pnpm](https://pnpm.io/installation#using-npm) as package manager.
7979

8080
1. [Clone](https://help.github.com/en/articles/cloning-a-repository) this project with Git
81-
2. Install dependencies by running `npm install` within the cloned directory `third-stats/`
82-
3. Start the development server with `npm run dev`
81+
2. Install dependencies by running `pnpm install` within the cloned directory `third-stats/`
82+
3. Start the development server with `pnpm dev`
8383
4. Open development site by going to <http://localhost:8080> in your browser
8484

8585
Note that this tool uses [Thunderbirds WebExtension APIs](https://thunderbird-webextensions.readthedocs.io/en/latest/index.html). This means that some JavaScript objects won't be available in your browser as development environment. If you want to test your changes in Thunderbird, do the following:
8686

87-
5. Save all your changes and run `npm run build` to create a production build in the `dist/` directory
87+
5. Save all your changes and run `pnpm build` to create a production build in the `dist/` directory
8888
6. Open Thunderbird, go to main menu > add-ons > gear menu > debug add-ons > This Thunderbird > Load temporary add-on
8989
7. Now choose the manifest file inside the `dist/` directory and your modified add-on will be loaded for the current Thunderbird session. You can check the web console by clicking the button *Inspect* in the add-on tile.
9090

0 commit comments

Comments
 (0)