Skip to content

Commit 2865457

Browse files
authored
style(workspaces): format journal tests for lint parity
Signed-off-by: Samuel K <skevetter@pm.me>
1 parent 11c9b19 commit 2865457

1 file changed

Lines changed: 28 additions & 10 deletions

File tree

pkg/workspacejournal/journal_test.go

Lines changed: 28 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,10 @@ func TestJournalRotatesFromHighestExistingSegment(t *testing.T) {
142142
if err != nil {
143143
t.Fatal(err)
144144
}
145-
if err := journal.Append("demo", status.Event{Phase: status.PhaseReady, State: status.StateSucceeded}); err != nil {
145+
if err := journal.Append(
146+
"demo",
147+
status.Event{Phase: status.PhaseReady, State: status.StateSucceeded},
148+
); err != nil {
146149
t.Fatal(err)
147150
}
148151
if _, err := os.Stat(filepath.Join(dir, "events-000004.ndjson")); err != nil {
@@ -165,7 +168,11 @@ func TestReadSkipsOversizedRecords(t *testing.T) {
165168
`"workspaceId":"demo","pipeline":"workspace_up","phase":"ready","state":"succeeded","step":"` +
166169
strings.Repeat("x", 128*1024) + `"}`
167170
contents := record + "\n" + oversized + "\n" + record + "\n"
168-
if err := os.WriteFile(filepath.Join(dir, "events-000001.ndjson"), []byte(contents), 0o600); err != nil {
171+
if err := os.WriteFile(
172+
filepath.Join(dir, "events-000001.ndjson"),
173+
[]byte(contents),
174+
0o600,
175+
); err != nil {
169176
t.Fatal(err)
170177
}
171178
events, err := Read(dir, "demo", 10)
@@ -179,14 +186,25 @@ func TestReadSkipsOversizedRecords(t *testing.T) {
179186

180187
func TestReadSkipsIncompleteRecords(t *testing.T) {
181188
dir := t.TempDir()
182-
base := `"schemaVersion":1,"timestamp":"2026-09-20T06:00:00Z",` +
183-
`"workspaceId":"demo","pipeline":"workspace_up","phase":"ready","state":"succeeded"`
184-
contents := "{" + base + "}\n" +
185-
`{"schemaVersion":1,"workspaceId":"demo","pipeline":"workspace_up","phase":"ready","state":"succeeded"}` + "\n" +
186-
`{"schemaVersion":1,"timestamp":"2026-09-20T06:00:00Z","workspaceId":"demo","phase":"ready","state":"succeeded"}` + "\n" +
187-
`{"schemaVersion":1,"timestamp":"2026-09-20T06:00:00Z","workspaceId":"demo","pipeline":"workspace_up","state":"succeeded"}` + "\n" +
188-
`{"schemaVersion":1,"timestamp":"2026-09-20T06:00:00Z","workspaceId":"demo","pipeline":"workspace_up","phase":"ready"}` + "\n"
189-
if err := os.WriteFile(filepath.Join(dir, "events-000001.ndjson"), []byte(contents), 0o600); err != nil {
189+
record := func(fields ...string) string {
190+
return "{" + strings.Join(fields, ",") + "}\n"
191+
}
192+
sv := `"schemaVersion":1`
193+
ts := `"timestamp":"2026-09-20T06:00:00Z"`
194+
ws := `"workspaceId":"demo"`
195+
pl := `"pipeline":"workspace_up"`
196+
ph := `"phase":"ready"`
197+
st := `"state":"succeeded"`
198+
contents := record(sv, ts, ws, pl, ph, st) +
199+
record(sv, ws, pl, ph, st) +
200+
record(sv, ts, ws, ph, st) +
201+
record(sv, ts, ws, pl, st) +
202+
record(sv, ts, ws, pl, ph)
203+
if err := os.WriteFile(
204+
filepath.Join(dir, "events-000001.ndjson"),
205+
[]byte(contents),
206+
0o600,
207+
); err != nil {
190208
t.Fatal(err)
191209
}
192210
events, err := Read(dir, "demo", 10)

0 commit comments

Comments
 (0)