Refactor: replace redundant boolean closure in makeAppStageStatus with id > 0 #6992

Feature description

In pkg/app/appDetails/read/AppDetailsReadService.go, makeAppStageStatus sets the Status field with an inline anonymous function:

Status: func() bool {
    if id > 0 {
        return true
    } else {
        return false
    }
}(),

AppStageStatus.Status is a bool, and the closure only returns id > 0. It can be written directly as Status: id > 0, which removes the branch and the per-call closure while producing the same value.

Location: pkg/app/appDetails/read/AppDetailsReadService.go lines 145-151.

Pitch / Usecases

The expression form reads more directly and drops an anonymous function that runs on every call to makeAppStageStatus. This is the same redundant-branch pattern already addressed in #6030 and #6031, and it is what gosimple (S1008) reports.

Alternative

None.

Have you spent some time to check if this issue has been raised before?

• I checked and did not find a similar issue

Have you read the Code of Conduct?

• I have read the Code of Conduct